Commit81c2321

committed

fix dumping number-like string parameters

1 parent3bd5fae commit81c2321Copy full SHA for 81c2321

File tree

+27

-0

lines changed

+27

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -304,6 +304,11 @@ private function convertParameters(array $parameters, $type, \DOMElement $parent`
`304`	`304`	`if (\in_array($value, ['null','true','false'],true)) {`
`305`	`305`	`$element->setAttribute('type','string');`
`306`	`306`	`}`
	`307`	`+`
	`308`	`+if (is_string($value) && (is_numeric($value) \|\|preg_match('/^0b[01]*$/',$value) \|\|preg_match('/^0x[0-9a-f]++$/i',$value))) {`
	`309`	`+$element->setAttribute('type','string');`
	`310`	`+ }`
	`311`	`+`
`307`	`312`	`$text =$this->document->createTextNode(self::phpToXml($value));`
`308`	`313`	`$element->appendChild($text);`
`309`	`314`	`}`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,17 @@`
`9`	`9`	`'bar' =>'foo is %%foo bar',`
`10`	`10`	`'escape' =>'@escapeme',`
`11`	`11`	`'values' => [true,false,null,0,1000.3,'true','false','null'],`
	`12`	`+'null string' =>'null',`
	`13`	`+'string of digits' =>'123',`
	`14`	`+'string of digits prefixed with minus character' =>'-123',`
	`15`	`+'true string' =>'true',`
	`16`	`+'false string' =>'false',`
	`17`	`+'binary number string' =>'0b0110',`
	`18`	`+'numeric string' =>'-1.2E2',`
	`19`	`+'hexadecimal number string' =>'0xFF',`
	`20`	`+'float string' =>'10100.1',`
	`21`	`+'positive float string' =>'+10100.1',`
	`22`	`+'negative float string' =>'-10100.1',`
`12`	`23`	`]));`
`13`	`24`
`14`	`25`	`return$container;`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,17 @@`
`18`	`18`	`<parametertype="string">false</parameter>`
`19`	`19`	`<parametertype="string">null</parameter>`
`20`	`20`	`</parameter>`
	`21`	`+ <parameterkey="null string"type="string">null</parameter>`
	`22`	`+ <parameterkey="string of digits"type="string">123</parameter>`
	`23`	`+ <parameterkey="string of digits prefixed with minus character"type="string">-123</parameter>`
	`24`	`+ <parameterkey="true string"type="string">true</parameter>`
	`25`	`+ <parameterkey="false string"type="string">false</parameter>`
	`26`	`+ <parameterkey="binary number string"type="string">0b0110</parameter>`
	`27`	`+ <parameterkey="numeric string"type="string">-1.2E2</parameter>`
	`28`	`+ <parameterkey="hexadecimal number string"type="string">0xFF</parameter>`
	`29`	`+ <parameterkey="float string"type="string">10100.1</parameter>`
	`30`	`+ <parameterkey="positive float string"type="string">+10100.1</parameter>`
	`31`	`+ <parameterkey="negative float string"type="string">-10100.1</parameter>`
`21`	`32`	`</parameters>`
`22`	`33`	`<services>`
`23`	`34`	`<serviceid="service_container"class="Symfony\Component\DependencyInjection\ContainerInterface"public="true"synthetic="true"/>`

Comments

(0)