NotificationsYou must be signed in to change notification settings
Fork9.8k
Star30.9k

Commit790ba4c

committed

feature#10534 [SwiftMailer] [MonologBundle] send error log mails from CLI (arodiss)

This PR was merged into the 2.5-dev branch.Discussion----------[SwiftMailer] [MonologBundle] send error log mails from CLI| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITGiven I have symfony2 application with Monolog configured to send mail on error logs.When I have exception thrown from CLI taskThen I should receive error mailHowever this is not true because `Monolog/SwiftMailerHandler` is doing force flush only on `kernel.terminate`, but not on `console.terminate`This PR fixes issue together withsymfony/monolog-bundle#73Commits-------9bb602f added explicit swiftmailer flush after ConsoleEvents::TERMINATE

2 parents9dc14a5 +9bb602f commit790ba4cCopy full SHA for 790ba4c

File tree

1 file changed

+11

-0

lines changed

src/Symfony/Bridge/Monolog/Handler
- SwiftMailerHandler.php

1 file changed

+11

-0

lines changed

`‎src/Symfony/Bridge/Monolog/Handler/SwiftMailerHandler.php‎`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespaceSymfony\Bridge\Monolog\Handler;`
`13`	`13`
`14`	`14`	`useMonolog\Handler\SwiftMailerHandlerasBaseSwiftMailerHandler;`
	`15`	`+useSymfony\Component\Console\Event\ConsoleTerminateEvent;`
`15`	`16`	`useSymfony\Component\HttpKernel\Event\PostResponseEvent;`
`16`	`17`
`17`	`18`	`/**`
`@@ -43,6 +44,16 @@ public function onKernelTerminate(PostResponseEvent $event)`
`43`	`44`	`$this->instantFlush =true;`
`44`	`45`	`}`
`45`	`46`
	`47`	`+/**`
	`48`	`+ * After the CLI application has been terminated we will always flush messages`
	`49`	`+ *`
	`50`	`+ * @param ConsoleTerminateEvent $event`
	`51`	`+ */`
	`52`	`+publicfunctiononCliTerminate(ConsoleTerminateEvent$event)`
	`53`	`+ {`
	`54`	`+$this->instantFlush =true;`
	`55`	`+ }`
	`56`	`+`
`46`	`57`	`/**`
`47`	`58`	`* {@inheritdoc}`
`48`	`59`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit790ba4c

File tree

1 file changed

1 file changed

`‎src/Symfony/Bridge/Monolog/Handler/SwiftMailerHandler.php‎`

0 commit comments