NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit77d06b5

committed

bug#23341 [DoctrineBridge][Security][Validator] do not validate empty values (xabbuh)

This PR was merged into the 2.7 branch.Discussion----------[DoctrineBridge][Security][Validator] do not validate empty values| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23319| License | MIT| Doc PR |Nearly all validators operating on scalar values (except for some special constraints) do ignore empty values. If you want to forbid them, you have to use the `NotBlank` constraint instead.Commits-------fd7ad23 do not validate empty values

2 parents4e65c1f +fd7ad23 commit77d06b5Copy full SHA for 77d06b5

File tree

3 files changed

-1

lines changed

src/Symfony
- Bridge/Doctrine/Validator/Constraints
  - UniqueEntityValidator.php
- Component
  - Security/Core/Validator/Constraints
    - UserPasswordValidator.php
  - Validator/Constraints
    - UrlValidator.php

3 files changed

-1

lines changed

`‎src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,10 @@ public function validate($entity, Constraint $constraint)`
`62`	`62`	`thrownewConstraintDefinitionException('At least one field has to be specified.');`
`63`	`63`	`}`
`64`	`64`
	`65`	`+if (null ===$entity) {`
	`66`	`+return;`
	`67`	`+ }`
	`68`	`+`
`65`	`69`	`if ($constraint->em) {`
`66`	`70`	`$em =$this->registry->getManager($constraint->em);`
`67`	`71`

`‎src/Symfony/Component/Security/Core/Validator/Constraints/UserPasswordValidator.php‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ public function validate($password, Constraint $constraint)`
`39`	`39`	`thrownewUnexpectedTypeException($constraint,__NAMESPACE__.'\UserPassword');`
`40`	`40`	`}`
`41`	`41`
	`42`	`+if (null ===$password \|\|'' ===$password) {`
	`43`	`+return;`
	`44`	`+ }`
	`45`	`+`
`42`	`46`	`$user =$this->tokenStorage->getToken()->getUser();`
`43`	`47`
`44`	`48`	`if (!$userinstanceof UserInterface) {`

`‎src/Symfony/Component/Validator/Constraints/UrlValidator.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function validate($value, Constraint $constraint)`
`48`	`48`	`thrownewUnexpectedTypeException($constraint,__NAMESPACE__.'\Url');`
`49`	`49`	`}`
`50`	`50`
`51`		`-if (null ===$value) {`
	`51`	`+if (null ===$value \|\|'' ===$value) {`
`52`	`52`	`return;`
`53`	`53`	`}`
`54`	`54`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit77d06b5

File tree

3 files changed

3 files changed

`‎src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php‎`

`‎src/Symfony/Component/Security/Core/Validator/Constraints/UserPasswordValidator.php‎`

`‎src/Symfony/Component/Validator/Constraints/UrlValidator.php‎`

0 commit comments