NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Commit757fcbb

committed

bug#59796 [Mime] use address for body atPathHeader (tinect)

This PR was merged into the 6.4 branch.Discussion----------[Mime] use address for body at `PathHeader`| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | Fix #... | License | MITWe noticed, that ReturnPath has wrong content in EML if any library is forcing key=>value.Setting it to `mail@example.com`, results into `<"mail@example.com" <mail@example.com>>` after stringify it which is not compliant: `Email \"\"mail@example.com"<mail@example.com\" does not comply with addr-spec of RFC 2822.`Commits-------0d4a498 [MIME] use address for body at PathHeader

2 parentsf48cf1b +0d4a498 commit757fcbbCopy full SHA for 757fcbb

File tree

2 files changed

-1

lines changed

src/Symfony/Component/Mime
- Header
  - PathHeader.php
- Tests/Header
  - HeadersTest.php

2 files changed

-1

lines changed

`‎src/Symfony/Component/Mime/Header/PathHeader.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,6 @@ public function getAddress(): Address`
`57`	`57`
`58`	`58`	`publicfunctiongetBodyAsString():string`
`59`	`59`	`{`
`60`		`-return'<'.$this->address->toString().'>';`
	`60`	`+return'<'.$this->address->getEncodedAddress().'>';`
`61`	`61`	`}`
`62`	`62`	`}`

`‎src/Symfony/Component/Mime/Tests/Header/HeadersTest.php`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -346,4 +346,12 @@ public function testSetHeaderParameterNotParameterized()`
`346`	`346`	`$this->expectException(\LogicException::class);`
`347`	`347`	`$headers->setHeaderParameter('Content-Disposition','name','foo');`
`348`	`348`	`}`
	`349`	`+`
	`350`	`+publicfunctiontestPathHeaderHasNoName()`
	`351`	`+ {`
	`352`	`+$headers =newHeaders();`
	`353`	`+`
	`354`	`+$headers->addPathHeader('Return-Path',newAddress('some@path','any ignored name'));`
	`355`	`+$this->assertSame('<some@path>',$headers->get('Return-Path')->getBodyAsString());`
	`356`	`+ }`
`349`	`357`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit757fcbb

File tree

2 files changed

2 files changed

`‎src/Symfony/Component/Mime/Header/PathHeader.php`

`‎src/Symfony/Component/Mime/Tests/Header/HeadersTest.php`

0 commit comments