Movatterモバイル変換

Skip to content

symfony/symfonyPublic

NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit6dfa363

nicolas-grekas

committed

feature#53151 mark classes implementing theWarmableInterface asfinal (xabbuh)

This PR was merged into the 7.1 branch.Discussion----------mark classes implementing the `WarmableInterface` as `final`| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITCommits-------a1cdb47 mark classes implementing the WarmableInterface as final

2 parentsf63c682 +a1cdb47 commit6dfa363Copy full SHA for 6dfa363

File tree

16 files changed

+57

-18

lines changed

UPGRADE-7.1.md
src/Symfony
- Bridge/Doctrine/CacheWarmer
  - ProxyCacheWarmer.php
- Bundle
  - FrameworkBundle
    - CHANGELOG.md
    - CacheWarmer
    - Routing
      - Router.php
    - Tests/Translation
      - TranslatorTest.php
    - Translation
      - Translator.php
  - SecurityBundle
    - CHANGELOG.md
    - CacheWarmer
      - ExpressionCacheWarmer.php
  - TwigBundle
    - CHANGELOG.md
    - CacheWarmer
      - TemplateCacheWarmer.php
- Component/Translation
  - CHANGELOG.md
  - DataCollectorTranslator.php

16 files changed

+57

-18

lines changed

`‎UPGRADE-7.1.md‎`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,31 @@ Cache`
`6`	`6`
`7`	`7`	* Deprecate`CouchbaseBucketAdapter`, use`CouchbaseCollectionAdapter` instead
`8`	`8`
	`9`	`+FrameworkBundle`
	`10`	`+---------------`
	`11`	`+`
	`12`	+* Mark classes`ConfigBuilderCacheWarmer`,`Router`,`SerializerCacheWarmer`,`TranslationsCacheWarmer`,`Translator` and`ValidatorCacheWarmer` as`final`
	`13`	`+`
`9`	`14`	`Messenger`
`10`	`15`	`---------`
`11`	`16`
`12`	`17`	* Make`#[AsMessageHandler]` final
`13`	`18`
	`19`	`+SecurityBundle`
	`20`	`+--------------`
	`21`	`+`
	`22`	+* Mark class`ExpressionCacheWarmer` as`final`
	`23`	`+`
	`24`	`+Translation`
	`25`	`+-----------`
	`26`	`+`
	`27`	+* Mark class`DataCollectorTranslator` as`final`
	`28`	`+`
	`29`	`+TwigBundle`
	`30`	`+----------`
	`31`	`+`
	`32`	+* Mark class`TemplateCacheWarmer` as`final`
	`33`	`+`
`14`	`34`	`Workflow`
`15`	`35`	`--------`
`16`	`36`

`‎src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`	`* since this information is necessary to build the proxies in the first place.`
`22`	`22`	`*`
`23`	`23`	`* @author Benjamin Eberlei <kontakt@beberlei.de>`
	`24`	`+ *`
	`25`	`+ * @final since Symfony 7.1`
`24`	`26`	`*/`
`25`	`27`	`class ProxyCacheWarmerimplements CacheWarmerInterface`
`26`	`28`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ CHANGELOG`
`4`	`4`	`7.1`
`5`	`5`	`---`
`6`	`6`
	`7`	+* Mark classes`ConfigBuilderCacheWarmer`,`Router`,`SerializerCacheWarmer`,`TranslationsCacheWarmer`,`Translator` and`ValidatorCacheWarmer` as`final`
`7`	`8`	* Move the Router`cache_dir` to`kernel.build_dir`
`8`	`9`	* Deprecate the`router.cache_dir` config option
`9`	`10`	* Add`rate_limiter` tags to rate limiter services

`‎src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@`
`25`	`25`	`* Generate all config builders.`
`26`	`26`	`*`
`27`	`27`	`* @author Tobias Nyholm <tobias.nyholm@gmail.com>`
	`28`	`+ *`
	`29`	`+ * @final since Symfony 7.1`
`28`	`30`	`*/`
`29`	`31`	`class ConfigBuilderCacheWarmerimplements CacheWarmerInterface`
`30`	`32`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/CacheWarmer/SerializerCacheWarmer.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`	`* Warms up XML and YAML serializer metadata.`
`24`	`24`	`*`
`25`	`25`	`* @author Titouan Galopin <galopintitouan@gmail.com>`
	`26`	`+ *`
	`27`	`+ * @final since Symfony 7.1`
`26`	`28`	`*/`
`27`	`29`	`class SerializerCacheWarmerextends AbstractPhpFileCacheWarmer`
`28`	`30`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/CacheWarmer/TranslationsCacheWarmer.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`	`* Generates the catalogues for translations.`
`22`	`22`	`*`
`23`	`23`	`* @author Xavier Leune <xavier.leune@gmail.com>`
	`24`	`+ *`
	`25`	`+ * @final since Symfony 7.1`
`24`	`26`	`*/`
`25`	`27`	`class TranslationsCacheWarmerimplements CacheWarmerInterface, ServiceSubscriberInterface`
`26`	`28`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ValidatorCacheWarmer.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@`
`24`	`24`	`* Warms up XML and YAML validator metadata.`
`25`	`25`	`*`
`26`	`26`	`* @author Titouan Galopin <galopintitouan@gmail.com>`
	`27`	`+ *`
	`28`	`+ * @final since Symfony 7.1`
`27`	`29`	`*/`
`28`	`30`	`class ValidatorCacheWarmerextends AbstractPhpFileCacheWarmer`
`29`	`31`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/Routing/Router.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,8 @@`
`30`	`30`	`* This Router creates the Loader only when the cache is empty.`
`31`	`31`	`*`
`32`	`32`	`* @author Fabien Potencier <fabien@symfony.com>`
	`33`	`+ *`
	`34`	`+ * @final since Symfony 7.1`
`33`	`35`	`*/`
`34`	`36`	`class Routerextends BaseRouterimplements WarmableInterface, ServiceSubscriberInterface`
`35`	`37`	`{`

`‎src/Symfony/Bundle/FrameworkBundle/Tests/Translation/TranslatorTest.php‎`

Lines changed: 0 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,16 +100,6 @@ public function testTransWithCaching()`
`100`	`100`	`$this->assertEquals('foobarbax (sr@latin)',$translator->trans('foobarbax'));`
`101`	`101`	`}`
`102`	`102`
`103`		`-publicfunctiontestTransWithCachingWithInvalidLocale()`
`104`		`- {`
`105`		`-$this->expectException(\InvalidArgumentException::class);`
`106`		`-$this->expectExceptionMessage('Invalid "invalid locale" locale.');`
`107`		`-$loader =$this->createMock(LoaderInterface::class);`
`108`		`-$translator =$this->getTranslator($loader, ['cache_dir' =>$this->tmpDir],'loader', TranslatorWithInvalidLocale::class);`
`109`		`-`
`110`		`-$translator->trans('foo');`
`111`		`- }`
`112`		`-`
`113`	`103`	`publicfunctiontestLoadResourcesWithoutCaching()`
`114`	`104`	`{`
`115`	`105`	`$loader =newYamlFileLoader();`
`@@ -418,11 +408,3 @@ private function createTranslator($loader, $options, $translatorClass = Translat`
`418`	`408`	`);`
`419`	`409`	`}`
`420`	`410`	`}`
`421`		`-`
`422`		`-class TranslatorWithInvalidLocaleextends Translator`
`423`		`-{`
`424`		`-publicfunctiongetLocale():string`
`425`		`- {`
`426`		`-return'invalid locale';`
`427`		`- }`
`428`		`-}`

`‎src/Symfony/Bundle/FrameworkBundle/Translation/Translator.php‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`
`22`	`22`	`/**`
`23`	`23`	`* @author Fabien Potencier <fabien@symfony.com>`
	`24`	`+ *`
	`25`	`+ * @final since Symfony 7.1`
`24`	`26`	`*/`
`25`	`27`	`class Translatorextends BaseTranslatorimplements WarmableInterface`
`26`	`28`	`{`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp