NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit6935e5a

committed

bug#25559 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions (nicolas-grekas)

This PR was merged into the 3.3 branch.Discussion----------[Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25511| License | MIT| Doc PR | -Commits-------0d4bce6 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions

2 parentsd731a27 +0d4bce6 commit6935e5aCopy full SHA for 6935e5a

File tree

1 file changed

-8

lines changed

src/Symfony/Component/Process
- Process.php

1 file changed

-8

lines changed

`‎src/Symfony/Component/Process/Process.php‎`

Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1718,15 +1718,11 @@ private function escapeArgument($argument)`
`1718`	`1718`
`1719`	`1719`	`privatefunctiongetDefaultEnv()`
`1720`	`1720`	`{`
`1721`		`-if (\PHP_VERSION_ID >=70100) {`
`1722`		`-$env =getenv();`
`1723`		`- }else {`
`1724`		`-$env =array();`
	`1721`	`+$env =array();`
`1725`	`1722`
`1726`		`-foreach ($_SERVERas$k =>$v) {`
`1727`		`-if (is_string($v) &&false !==$v =getenv($k)) {`
`1728`		`-$env[$k] =$v;`
`1729`		`- }`
	`1723`	`+foreach ($_SERVERas$k =>$v) {`
	`1724`	`+if (is_string($v) &&false !==$v =getenv($k)) {`
	`1725`	`+$env[$k] =$v;`
`1730`	`1726`	`}`
`1731`	`1727`	`}`
`1732`	`1728`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit6935e5a

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Process/Process.php‎`

0 commit comments