NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit66f6e8e

Amrouche Hamza

committed

add tests

1 parent9b8397b commit66f6e8eCopy full SHA for 66f6e8e

File tree

3 files changed

+42

-1

lines changed

src/Symfony/Component/DependencyInjection
- Compiler
  - AutowirePass.php
- Tests/Compiler
  - AutowirePassTest.php
  - ResolveBindingsPassTest.php

3 files changed

+42

-1

lines changed

`‎src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php‎`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,15 @@ private function autowireCalls(\ReflectionClass $reflectionClass, bool $isRoot):`
`158`	`158`	`if ($methodinstanceof \ReflectionFunctionAbstract) {`
`159`	`159`	`$reflectionMethod =$method;`
`160`	`160`	`}else {`
`161`		`-$reflectionMethod =$this->getReflectionMethod(newDefinition($reflectionClass->name),$method);`
	`161`	`+$definition =newDefinition($reflectionClass->name);`
	`162`	`+try {`
	`163`	`+$reflectionMethod =$this->getReflectionMethod($definition,$method);`
	`164`	`+ }catch (RuntimeException$e) {`
	`165`	`+if ($definition->getFactory()) {`
	`166`	`+continue;`
	`167`	`+ }`
	`168`	`+throw$e;`
	`169`	`+ }`
`162`	`170`	`}`
`163`	`171`
`164`	`172`	`$arguments =$this->autowireMethod($reflectionMethod,$arguments);`

`‎src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php‎`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@`
`26`	`26`	`useSymfony\Component\DependencyInjection\Reference;`
`27`	`27`	`useSymfony\Component\DependencyInjection\Tests\Fixtures\includes\FooVariadic;`
`28`	`28`	`useSymfony\Component\DependencyInjection\TypedReference;`
	`29`	`+useSymfony\Component\HttpKernel\HttpKernelInterface;`
`29`	`30`
`30`	`31`	`require_once__DIR__.'/../Fixtures/includes/autowiring_classes.php';`
`31`	`32`
`@@ -545,6 +546,18 @@ public function testSetterInjection()`
`545`	`546`	`);`
`546`	`547`	`}`
`547`	`548`
	`549`	`+publicfunctiontestWithNonExistingSetterAndAutowiring()`
	`550`	`+ {`
	`551`	`+$container =newContainerBuilder();`
	`552`	`+`
	`553`	`+$definition =$container->register(HttpKernelInterface::class, HttpKernelInterface::class)->setAutowired(true);`
	`554`	`+$definition->addMethodCall('setLogger');`
	`555`	`+$this->expectException(RuntimeException::class);`
	`556`	`+ (newResolveClassPass())->process($container);`
	`557`	`+ (newAutowireRequiredMethodsPass())->process($container);`
	`558`	`+ (newAutowirePass())->process($container);`
	`559`	`+ }`
	`560`	`+`
`548`	`561`	`publicfunctiontestExplicitMethodInjection()`
`549`	`562`	`{`
`550`	`563`	`$container =newContainerBuilder();`

`‎src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php‎`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,14 @@`
`16`	`16`	`useSymfony\Component\DependencyInjection\Compiler\AutowireRequiredMethodsPass;`
`17`	`17`	`useSymfony\Component\DependencyInjection\Compiler\ResolveBindingsPass;`
`18`	`18`	`useSymfony\Component\DependencyInjection\ContainerBuilder;`
	`19`	`+useSymfony\Component\DependencyInjection\Definition;`
	`20`	`+useSymfony\Component\DependencyInjection\Exception\RuntimeException;`
`19`	`21`	`useSymfony\Component\DependencyInjection\Reference;`
`20`	`22`	`useSymfony\Component\DependencyInjection\Tests\Fixtures\CaseSensitiveClass;`
`21`	`23`	`useSymfony\Component\DependencyInjection\Tests\Fixtures\NamedArgumentsDummy;`
`22`	`24`	`useSymfony\Component\DependencyInjection\Tests\Fixtures\ParentNotExists;`
`23`	`25`	`useSymfony\Component\DependencyInjection\TypedReference;`
	`26`	`+useSymfony\Component\HttpKernel\HttpKernelInterface;`
`24`	`27`
`25`	`28`	`require_once__DIR__.'/../Fixtures/includes/autowiring_classes.php';`
`26`	`29`
`@@ -112,6 +115,23 @@ public function testScalarSetter()`
`112`	`115`	`$this->assertEquals([['setDefaultLocale', ['fr']]],$definition->getMethodCalls());`
`113`	`116`	`}`
`114`	`117`
	`118`	`+publicfunctiontestWithNonExistingSetterAndBinding()`
	`119`	`+ {`
	`120`	`+$container =newContainerBuilder();`
	`121`	`+`
	`122`	`+$bindings = [`
	`123`	`+'$c' => (newDefinition('logger'))->setFactory('logger'),`
	`124`	`+ ];`
	`125`	`+`
	`126`	`+$definition =$container->register(HttpKernelInterface::class, HttpKernelInterface::class);`
	`127`	`+$definition->addMethodCall('setLogger');`
	`128`	`+$definition->setBindings($bindings);`
	`129`	`+$this->expectException(RuntimeException::class);`
	`130`	`+`
	`131`	`+$pass =newResolveBindingsPass();`
	`132`	`+$pass->process($container);`
	`133`	`+ }`
	`134`	`+`
`115`	`135`	`publicfunctiontestTupleBinding()`
`116`	`136`	`{`
`117`	`137`	`$container =newContainerBuilder();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit66f6e8e

File tree

3 files changed

3 files changed

`‎src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php‎`

`‎src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php‎`

`‎src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveBindingsPassTest.php‎`

0 commit comments