NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit626d93d

committed

[Serializer] AbstractObjectNormalizer improve perf when checking types

1 parentff1727e commit626d93dCopy full SHA for 626d93d

File tree

1 file changed

+11

-3

lines changed

src/Symfony/Component/Serializer/Normalizer
- AbstractObjectNormalizer.php

1 file changed

+11

-3

lines changed

`‎src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php‎`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ abstract class AbstractObjectNormalizer extends AbstractNormalizer`
`37`	`37`	`constDISABLE_TYPE_ENFORCEMENT ='disable_type_enforcement';`
`38`	`38`
`39`	`39`	`private$propertyTypeExtractor;`
	`40`	`+private$typesCache =array();`
`40`	`41`	`private$attributesCache =array();`
`41`	`42`
`42`	`43`	`/**`
`@@ -366,24 +367,31 @@ private function getTypes(string $currentClass, string $attribute)`
`366`	`367`	`returnnull;`
`367`	`368`	`}`
`368`	`369`
	`370`	`+$key =$currentClass.'::'.$attribute;`
	`371`	`+if (isset($this->typesCache[$key])) {`
	`372`	`+return$this->typesCache[$key] ===false ?null :$this->typesCache[$key];`
	`373`	`+ }`
	`374`	`+`
`369`	`375`	`if (null !==$types =$this->propertyTypeExtractor->getTypes($currentClass,$attribute)) {`
`370`		`-return$types;`
	`376`	`+return$this->typesCache[$key] =$types;`
`371`	`377`	`}`
`372`	`378`
`373`	`379`	`if (null !==$this->classDiscriminatorResolver &&null !==$discriminatorMapping =$this->classDiscriminatorResolver->getMappingForClass($currentClass)) {`
`374`	`380`	`if ($discriminatorMapping->getTypeProperty() ===$attribute) {`
`375`		`-returnarray(`
	`381`	`+return$this->typesCache[$key] =array(`
`376`	`382`	`newType(Type::BUILTIN_TYPE_STRING),`
`377`	`383`	`);`
`378`	`384`	`}`
`379`	`385`
`380`	`386`	`foreach ($discriminatorMapping->getTypesMapping()as$mappedClass) {`
`381`	`387`	`if (null !==$types =$this->propertyTypeExtractor->getTypes($mappedClass,$attribute)) {`
`382`		`-return$types;`
	`388`	`+return$this->typesCache[$key] =$types;`
`383`	`389`	`}`
`384`	`390`	`}`
`385`	`391`	`}`
`386`	`392`
	`393`	`+$this->typesCache[$key] =false;`
	`394`	`+`
`387`	`395`	`returnnull;`
`388`	`396`	`}`
`389`	`397`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit626d93d

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php‎`

0 commit comments