NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit5d7b7e9

committed

bug#36915 [DomCrawler] Catch expected ValueError (derrabus)

This PR was merged into the 4.4 branch.Discussion----------[DomCrawler] Catch expected ValueError| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#36872| License | MIT| Doc PR | N/AThis is#36906 ported to the 4.4 branch.Commits-------32691e5 [DomCrawler] Catch expected ValueError.

2 parentsa25e88b +32691e5 commit5d7b7e9Copy full SHA for 5d7b7e9

File tree

1 file changed

-2

lines changed

src/Symfony/Component/DomCrawler
- Crawler.php

1 file changed

-2

lines changed

`‎src/Symfony/Component/DomCrawler/Crawler.php‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1204,11 +1204,11 @@ private function convertToHtmlEntities(string $htmlContent, string $charset = 'U`
`1204`	`1204`
`1205`	`1205`	`try {`
`1206`	`1206`	`returnmb_convert_encoding($htmlContent,'HTML-ENTITIES',$charset);`
`1207`		`- }catch (\Exception$e) {`
	`1207`	`+ }catch (\Exception\|\ValueError$e) {`
`1208`	`1208`	`try {`
`1209`	`1209`	`$htmlContent =iconv($charset,'UTF-8',$htmlContent);`
`1210`	`1210`	`$htmlContent =mb_convert_encoding($htmlContent,'HTML-ENTITIES','UTF-8');`
`1211`		`- }catch (\Exception$e) {`
	`1211`	`+ }catch (\Exception\|\ValueError$e) {`
`1212`	`1212`	`}`
`1213`	`1213`
`1214`	`1214`	`return$htmlContent;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit5d7b7e9

File tree

1 file changed

1 file changed

`‎src/Symfony/Component/DomCrawler/Crawler.php‎`

0 commit comments