Commit572e02c

committed

[HttpFoundation] Fix caching of session-enabled pages

1 parented8c731 commit572e02cCopy full SHA for 572e02c

File tree

-3

lines changed

src/Symfony/Component/HttpFoundation
- Session/Storage
  - NativeSessionStorage.php
- Tests/Session/Storage/Handler/Fixtures
  - storage.expected

-3

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,8 @@ class NativeSessionStorage implements SessionStorageInterface`
`60`	`60`	`* ("auto_start", is not supported as it tells PHP to start a session before`
`61`	`61`	`* PHP starts to execute user-land code. Setting during runtime has no effect).`
`62`	`62`	`*`
`63`		`- * cache_limiter, "" (use "0" to prevent headers from being sent entirely).`
	`63`	`+ * cache_limiter, "private_no_expire" (use "0" to prevent headers from being sent entirely).`
	`64`	`+ * cache_expire, "0"`
`64`	`65`	`* cookie_domain, ""`
`65`	`66`	`* cookie_httponly, ""`
`66`	`67`	`* cookie_lifetime, "0"`
`@@ -101,6 +102,7 @@ public function __construct(array $options = array(), $handler = null, MetadataB`
`101`	`102`	`{`
`102`	`103`	`$options +=array(`
`103`	`104`	`'cache_limiter' =>'private_no_expire',`
	`105`	`+'cache_expire' =>0,`
`104`	`106`	`'use_cookies' =>1,`
`105`	`107`	`'lazy_write' =>1,`
`106`	`108`	`);`
`@@ -347,7 +349,7 @@ public function setOptions(array $options)`
`347`	`349`	`}`
`348`	`350`
`349`	`351`	`$validOptions =array_flip(array(`
`350`		`-'cache_limiter','cookie_domain','cookie_httponly',`
	`352`	`+'cache_limiter','cache_expire','cookie_domain','cookie_httponly',`
`351`	`353`	`'cookie_lifetime','cookie_path','cookie_secure',`
`352`	`354`	`'entropy_file','entropy_length','gc_divisor',`
`353`	`355`	`'gc_maxlifetime','gc_probability','hash_bits_per_character',`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,6 @@ $_SESSION is not empty`
`15`	`15`	`Array`
`16`	`16`	`(`
`17`	`17`	`[0] => Content-Type: text/plain; charset=utf-8`
`18`		`- [1] => Cache-Control: private, max-age=10800`
	`18`	`+ [1] => Cache-Control: private, max-age=0`
`19`	`19`	`)`
`20`	`20`	`shutdown`

Comments

(0)