Commit4f9eedf

committed

[RateLimiter] Fix infinite values with NoLimiter

1 parent3811030 commit4f9eedfCopy full SHA for 4f9eedf

File tree

+34

-2

lines changed

src/Symfony/Component/RateLimiter
- Policy
  - NoLimiter.php
- Tests/Policy
  - NoLimiterTest.php

+34

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,12 @@ final class NoLimiter implements LimiterInterface`
`29`	`29`	`{`
`30`	`30`	`publicfunctionreserve(int$tokens =1, ?float$maxTime =null):Reservation`
`31`	`31`	`{`
`32`		`-returnnewReservation(time(),newRateLimit(\INF,new \DateTimeImmutable(),true, \INF));`
	`32`	`+returnnewReservation(time(),newRateLimit(\PHP_INT_MAX,new \DateTimeImmutable(),true, \PHP_INT_MAX));`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`publicfunctionconsume(int$tokens =1):RateLimit`
`36`	`36`	`{`
`37`		`-returnnewRateLimit(\INF,new \DateTimeImmutable(),true, \INF);`
	`37`	`+returnnewRateLimit(\PHP_INT_MAX,new \DateTimeImmutable(),true, \PHP_INT_MAX);`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`publicfunctionreset():void`

Lines changed: 32 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,32 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+/*`
	`4`	`+ * This file is part of the Symfony package.`
	`5`	`+ *`
	`6`	`+ * (c) Fabien Potencier <fabien@symfony.com>`
	`7`	`+ *`
	`8`	`+ * For the full copyright and license information, please view the LICENSE`
	`9`	`+ * file that was distributed with this source code.`
	`10`	`+ */`
	`11`	`+`
	`12`	`+namespaceSymfony\Component\RateLimiter\Tests\Policy;`
	`13`	`+`
	`14`	`+usePHPUnit\Framework\TestCase;`
	`15`	`+useSymfony\Component\RateLimiter\Policy\NoLimiter;`
	`16`	`+useSymfony\Component\RateLimiter\RateLimit;`
	`17`	`+useSymfony\Component\RateLimiter\Reservation;`
	`18`	`+`
	`19`	`+class NoLimiterTestextends TestCase`
	`20`	`+{`
	`21`	`+publicfunctiontestConsume()`
	`22`	`+ {`
	`23`	`+$limiter =newNoLimiter();`
	`24`	`+$this->assertInstanceOf(RateLimit::class,$limiter->consume());`
	`25`	`+ }`
	`26`	`+`
	`27`	`+publicfunctiontestReserve()`
	`28`	`+ {`
	`29`	`+$limiter =newNoLimiter();`
	`30`	`+$this->assertInstanceOf(Reservation::class,$limiter->reserve());`
	`31`	`+ }`
	`32`	`+}`

Comments

(0)