NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit324b512

committed

[Console]Fixed#29835: ConfirmationQuestion with default true for answer '0'

When using the ConfirmationQuestion class to ask a yes / no question,if the default is true, and the answer regex is '/^y/i', then anyvalue not starting with [yY] is considered false.This must include "0"

1 parent4ed009b commit324b512Copy full SHA for 324b512

File tree

2 files changed

-2

lines changed

src/Symfony/Component/Console
- Question
  - ConfirmationQuestion.php
- Tests/Question
  - ConfirmationQuestionTest.php

2 files changed

-2

lines changed

`‎src/Symfony/Component/Console/Question/ConfirmationQuestion.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ private function getDefaultNormalizer()`
`53`	`53`	`return$answer &&$answerIsTrue;`
`54`	`54`	`}`
`55`	`55`
`56`		`-return!$answer \|\|$answerIsTrue;`
	`56`	`+return'' ===$answer \|\|$answerIsTrue;`
`57`	`57`	`};`
`58`	`58`	`}`
`59`	`59`	`}`

`‎src/Symfony/Component/Console/Tests/Question/ConfirmationQuestionTest.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function normalizerUsecases()`
`40`	`40`	`],`
`41`	`41`	`[`
`42`	`42`	`true,`
`43`		`- ['n','N','no','NO','nO','foo','1'],`
	`43`	`+ ['n','N','no','NO','nO','foo','1','0'],`
`44`	`44`	`false,`
`45`	`45`	`'When default is true, the normalizer must return false for "%s"',`
`46`	`46`	`],`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit324b512

File tree

2 files changed

2 files changed

`‎src/Symfony/Component/Console/Question/ConfirmationQuestion.php‎`

`‎src/Symfony/Component/Console/Tests/Question/ConfirmationQuestionTest.php‎`

0 commit comments