Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2de7f94

Browse files
committed
Failing test for data collector bug
#20698 ,#20762
1 parente765849 commit2de7f94

File tree

2 files changed

+112
-1
lines changed

2 files changed

+112
-1
lines changed

‎src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ public function serialize()
256256
case'resolved_options':
257257
case'default_data':
258258
case'submitted_data':
259-
if ($v) {
259+
if (is_array($v)) {
260260
$form[$k] =array_map($cloneVar,$v);
261261
}
262262
break;

‎src/Symfony/Component/Form/Tests/Extension/DataCollector/FormDataCollectorTest.php

Lines changed: 111 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,117 @@ public function testBuildFinalFormTree()
342342
),$this->dataCollector->getData());
343343
}
344344

345+
publicfunctiontestSerializeWithFormAddedMultipleTimes()
346+
{
347+
$form1 =$this->createForm('form1');
348+
$form2 =$this->createForm('form2');
349+
$child1 =$this->createForm('child1');
350+
351+
$form1View =newFormView();
352+
$form2View =newFormView();
353+
$child1View =newFormView();
354+
$child1View->vars['is_selected'] =function ($choice,array$values) {
355+
returnin_array($choice,$values,true);
356+
};
357+
358+
$form1->add($child1);
359+
$form2->add($child1);
360+
361+
$form1View->children['child1'] =$child1View;
362+
$form2View->children['child1'] =$child1View;
363+
364+
365+
$this->dataExtractor->expects($this->at(0))
366+
->method('extractConfiguration')
367+
->with($form1)
368+
->will($this->returnValue(array('config' =>'foo')));
369+
$this->dataExtractor->expects($this->at(1))
370+
->method('extractConfiguration')
371+
->with($child1)
372+
->will($this->returnValue(array('config' =>'bar')));
373+
374+
$this->dataExtractor->expects($this->at(2))
375+
->method('extractDefaultData')
376+
->with($form1)
377+
->will($this->returnValue(array('default_data' =>'foo')));
378+
$this->dataExtractor->expects($this->at(3))
379+
->method('extractDefaultData')
380+
->with($child1)
381+
->will($this->returnValue(array('default_data' =>'bar')));
382+
383+
$this->dataExtractor->expects($this->at(4))
384+
->method('extractSubmittedData')
385+
->with($form1)
386+
->will($this->returnValue(array('submitted_data' =>'foo')));
387+
$this->dataExtractor->expects($this->at(5))
388+
->method('extractSubmittedData')
389+
->with($child1)
390+
->will($this->returnValue(array('submitted_data' =>'bar')));
391+
392+
$this->dataExtractor->expects($this->at(6))
393+
->method('extractViewVariables')
394+
->with($form1View)
395+
->will($this->returnValue(array('view_vars' =>'foo')));
396+
397+
$this->dataExtractor->expects($this->at(7))
398+
->method('extractViewVariables')
399+
->with($child1View)
400+
->will($this->returnValue(array('view_vars' =>$child1View->vars)));
401+
402+
403+
$this->dataExtractor->expects($this->at(8))
404+
->method('extractConfiguration')
405+
->with($form2)
406+
->will($this->returnValue(array('config' =>'foo')));
407+
$this->dataExtractor->expects($this->at(9))
408+
->method('extractConfiguration')
409+
->with($child1)
410+
->will($this->returnValue(array('config' =>'bar')));
411+
412+
$this->dataExtractor->expects($this->at(10))
413+
->method('extractDefaultData')
414+
->with($form2)
415+
->will($this->returnValue(array('default_data' =>'foo')));
416+
$this->dataExtractor->expects($this->at(11))
417+
->method('extractDefaultData')
418+
->with($child1)
419+
->will($this->returnValue(array('default_data' =>'bar')));
420+
421+
$this->dataExtractor->expects($this->at(12))
422+
->method('extractSubmittedData')
423+
->with($form2)
424+
->will($this->returnValue(array('submitted_data' =>'foo')));
425+
$this->dataExtractor->expects($this->at(13))
426+
->method('extractSubmittedData')
427+
->with($child1)
428+
->will($this->returnValue(array('submitted_data' =>'bar')));
429+
430+
$this->dataExtractor->expects($this->at(14))
431+
->method('extractViewVariables')
432+
->with($form2View)
433+
->will($this->returnValue(array('view_vars' =>'foo')));
434+
435+
$this->dataExtractor->expects($this->at(15))
436+
->method('extractViewVariables')
437+
->with($child1View)
438+
->will($this->returnValue(array('view_vars' =>$child1View->vars)));
439+
440+
441+
$this->dataCollector->collectConfiguration($form1);
442+
$this->dataCollector->collectDefaultData($form1);
443+
$this->dataCollector->collectSubmittedData($form1);
444+
$this->dataCollector->collectViewVariables($form1View);
445+
$this->dataCollector->buildFinalFormTree($form1,$form1View);
446+
447+
$this->dataCollector->collectConfiguration($form2);
448+
$this->dataCollector->collectDefaultData($form2);
449+
$this->dataCollector->collectSubmittedData($form2);
450+
$this->dataCollector->collectViewVariables($form2View);
451+
$this->dataCollector->buildFinalFormTree($form2,$form2View);
452+
453+
$this->dataCollector->serialize();
454+
}
455+
345456
publicfunctiontestFinalFormReliesOnFormViewStructure()
346457
{
347458
$this->form->add($child1 =$this->createForm('first'));

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp