Commit27d6697

committed

Fixed handling of CSRF logout error

1 parent4f40da5 commit27d6697Copy full SHA for 27d6697

File tree

+14

-1

lines changed

src/Symfony/Component/Security/Http
- Firewall
  - ExceptionListener.php
- Tests/Firewall
  - ExceptionListenerTest.php

+14

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,10 @@ private function handleAccessDeniedException(GetResponseForExceptionEvent $event`
`174`	`174`
`175`	`175`	`privatefunctionhandleLogoutException(LogoutException$exception)`
`176`	`176`	`{`
	`177`	`+$event->setException(newAccessDeniedHttpException($exception->getMessage(),$exception));`
	`178`	`+`
`177`	`179`	`if (null !==$this->logger) {`
`178`		`-$this->logger->info('A LogoutException was thrown.', ['exception' =>$exception]);`
	`180`	`+$this->logger->info('A LogoutException was thrown; wrapping with AccessDeniedHttpException', ['exception' =>$exception]);`
`179`	`181`	`}`
`180`	`182`	`}`
`181`	`183`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,17 @@ public function testAccessDeniedExceptionNotFullFledged(\Exception $exception, \`
`160`	`160`	`$this->assertSame(null ===$eventException ?$exception :$eventException,$event->getException()->getPrevious());`
`161`	`161`	`}`
`162`	`162`
	`163`	`+publicfunctiontestLogoutException()`
	`164`	`+ {`
	`165`	`+$event =$this->createEvent(newLogoutException('Invalid CSRF.'));`
	`166`	`+`
	`167`	`+$listener =$this->createExceptionListener();`
	`168`	`+$listener->onKernelException($event);`
	`169`	`+`
	`170`	`+$this->assertEquals('Forbidden',$event->getResponse()->getContent());`
	`171`	`+$this->assertEquals(403,$event->getResponse()->getStatusCode());`
	`172`	`+ }`
	`173`	`+`
`163`	`174`	`publicfunctiongetAccessDeniedExceptionProvider()`
`164`	`175`	`{`
`165`	`176`	`return [`

Comments

(0)