NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Commit26e2846

committed

bug#19904 [Form] Fixed collapsed ChoiceType options attributes (HeahDude)

This PR was merged into the 2.7 branch.Discussion----------[Form] Fixed collapsed ChoiceType options attributes| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19898| License | MIT| Doc PR | ~Commits-------7806e2a Fixed collapsed ChoiceType options attributes

2 parents354e8fd +7806e2a commit26e2846Copy full SHA for 26e2846

File tree

2 files changed

-3

lines changed

src/Symfony
- Bundle/FrameworkBundle/Resources/views/Form
  - choice_attributes.html.php
- Component/Form/Tests
  - AbstractLayoutTest.php

2 files changed

-3

lines changed

`‎src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/choice_attributes.html.php‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-id="<?phpecho$view->escape($id)?>" name="<?phpecho$view->escape($full_name)?>"`
`2`	`1`	`<?phpif ($disabled):?>disabled="disabled"<?phpendif?>`
`3`	`2`	`<?phpforeach ($choice_attras$k =>$v):?>`
`4`	`3`	`<?phpif ($v ===true):?>`

`‎src/Symfony/Component/Form/Tests/AbstractLayoutTest.php‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -612,8 +612,8 @@ public function testSingleChoiceAttributesWithMainAttributes()`
`612`	`612`	`[@class="bar&baz"]`
`613`	`613`	`[not(@required)]`
`614`	`614`	`[`
`615`		`- ./option[@value="&a"][@selected="selected"][.="[trans]Choice&A[/trans]"]`
`616`		`- /following-sibling::option[@value="&b"][not(@class)][not(@selected)][.="[trans]Choice&B[/trans]"]`
	`615`	`+ ./option[@value="&a"][@selected="selected"][.="[trans]Choice&A[/trans]"][not(@id)][not(@name)]`
	`616`	`+ /following-sibling::option[@value="&b"][not(@class)][not(@selected)][.="[trans]Choice&B[/trans]"][not(@id)][not(@name)]`
`617`	`617`	`]`
`618`	`618`	`[count(./option)=2]`
`619`	`619`	`'`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit26e2846

File tree

2 files changed

2 files changed

`‎src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/choice_attributes.html.php‎`

`‎src/Symfony/Component/Form/Tests/AbstractLayoutTest.php‎`

0 commit comments