Commit210e9e4

committed

skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5

1 parenta0deee5 commit210e9e4Copy full SHA for 210e9e4

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,11 @@ public function testBcryptWithNulByte()`
`103`	`103`	`$hasher =newNativePasswordHasher(null,null,4, \PASSWORD_BCRYPT);`
`104`	`104`	`$plainPassword ="a\0b";`
`105`	`105`
`106`		`-$this->assertFalse($hasher->verify(password_hash($plainPassword, \PASSWORD_BCRYPT, ['cost' =>4]),$plainPassword));`
	`106`	`+if (\PHP_VERSION_ID <80218 \|\| \PHP_VERSION_ID >=80300 && \PHP_VERSION_ID <80305) {`
	`107`	`+// password_hash() does not accept passwords containing NUL bytes since PHP 8.2.18 and 8.3.5`
	`108`	`+$this->assertFalse($hasher->verify(password_hash($plainPassword, \PASSWORD_BCRYPT, ['cost' =>4]),$plainPassword));`
	`109`	`+ }`
	`110`	`+`
`107`	`111`	`$this->assertTrue($hasher->verify($hasher->hash($plainPassword),$plainPassword));`
`108`	`112`	`}`
`109`	`113`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,11 @@ public function testBcryptWithNulByte()`
`78`	`78`	`$hasher =newSodiumPasswordHasher(null,null);`
`79`	`79`	`$plainPassword ="a\0b";`
`80`	`80`
`81`		`-$this->assertFalse($hasher->verify(password_hash($plainPassword, \PASSWORD_BCRYPT, ['cost' =>4]),$plainPassword));`
	`81`	`+if (\PHP_VERSION_ID <80218 \|\| \PHP_VERSION_ID >=80300 && \PHP_VERSION_ID <80305) {`
	`82`	`+// password_hash() does not accept passwords containing NUL bytes since PHP 8.2.18 and 8.3.5`
	`83`	`+$this->assertFalse($hasher->verify(password_hash($plainPassword, \PASSWORD_BCRYPT, ['cost' =>4]),$plainPassword));`
	`84`	`+ }`
	`85`	`+`
`82`	`86`	`$this->assertTrue($hasher->verify((newNativePasswordHasher(null,null,4, \PASSWORD_BCRYPT))->hash($plainPassword),$plainPassword));`
`83`	`87`	`}`
`84`	`88`

Comments

(0)