Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit166b527

Browse files
committed
bug#60373 [FrameworkBundle] EnsureEmail class exists before using it (Kocal)
This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Ensure `Email` class exists before using it| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MIT<!--Replace this notice by a description of your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->I think the [dev-tests suite from Symfony UX](https://github.com/symfony/ux/actions/runs/14886649078/job/41808040295?pr=2711) broke after#60365, see:```1) Symfony\UX\Icons\Tests\Integration\Command\ImportIconCommandTest::testCanImportIconError: Class "Symfony\Component\Validator\Constraints\Email" not found/home/runner/work/ux/ux/src/Icons/vendor/symfony/framework-bundle/DependencyInjection/Configuration.php:10[79](https://github.com/symfony/ux/actions/runs/14886649078/job/41808040295?pr=2711#step:8:80)/home/runner/work/ux/ux/src/Icons/vendor/symfony/framework-bundle/DependencyInjection/Configuration.php:163/home/runner/work/ux/ux/src/Icons/vendor/symfony/config/Definition/Processor.php:46/home/runner/work/ux/ux/src/Icons/vendor/symfony/dependency-injection/Extension/Extension.php:109/home/runner/work/ux/ux/src/Icons/vendor/symfony/framework-bundle/DependencyInjection/FrameworkExtension.php:306/home/runner/work/ux/ux/src/Icons/vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php:[81](https://github.com/symfony/ux/actions/runs/14886649078/job/41808040295?pr=2711#step:8:82)/home/runner/work/ux/ux/src/Icons/vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php:40/home/runner/work/ux/ux/src/Icons/vendor/symfony/dependency-injection/Compiler/Compiler.php:73/home/runner/work/ux/ux/src/Icons/vendor/symfony/dependency-injection/ContainerBuilder.php:813/home/runner/work/ux/ux/src/Icons/vendor/symfony/http-kernel/Kernel.php:499/home/runner/work/ux/ux/src/Icons/vendor/symfony/http-kernel/Kernel.php:744/home/runner/work/ux/ux/src/Icons/vendor/symfony/http-kernel/Kernel.php:120/home/runner/work/ux/ux/src/Icons/vendor/symfony/framework-bundle/Test/KernelTestCase.php:67/home/runner/work/ux/ux/src/Icons/vendor/zenstruck/console-test/src/InteractsWithConsole.php:40/home/runner/work/ux/ux/src/Icons/vendor/zenstruck/console-test/src/InteractsWithConsole.php:27/home/runner/work/ux/ux/src/Icons/tests/Integration/Command/ImportIconCommandTest.php:46```Commits-------680da0c [FrameworkBundle] Ensure `Email` class exists before using it
2 parents96120e6 +680da0c commit166b527

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1067,7 +1067,7 @@ private function addValidationSection(ArrayNodeDefinition $rootNode, callable $e
10671067
->validate()->castToArray()->end()
10681068
->end()
10691069
->scalarNode('translation_domain')->defaultValue('validators')->end()
1070-
->enumNode('email_validation_mode')->values(Email::VALIDATION_MODES + ['loose'])->end()
1070+
->enumNode('email_validation_mode')->values((class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld','html5','strict']) + ['loose'])->end()
10711071
->arrayNode('mapping')
10721072
->addDefaultsIfNotSet()
10731073
->fixXmlConfig('path')

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp