Commit1400f4e

committed

[Console] Bind the closure (code) to the Command if possible

1 parent862bdf1 commit1400f4eCopy full SHA for 1400f4e

File tree

+19

-0

lines changed

src/Symfony/Component/Console
- Command
  - Command.php
- Tests/Command
  - CommandTest.php

+19

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,6 +284,10 @@ public function setCode($code)`
`284`	`284`	`thrownew \InvalidArgumentException('Invalid callable provided to Command::setCode.');`
`285`	`285`	`}`
`286`	`286`
	`287`	`+if (PHP_VERSION_ID >=50400 &&$codeinstanceof \Closure) {`
	`288`	`+$code = \Closure::bind($code,$this);`
	`289`	`+ }`
	`290`	`+`
`287`	`291`	`$this->code =$code;`
`288`	`292`
`289`	`293`	`return$this;`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -293,6 +293,21 @@ public function testSetCode()`
`293`	`293`	`$this->assertEquals('interact called'.PHP_EOL.'from the code...'.PHP_EOL,$tester->getDisplay());`
`294`	`294`	`}`
`295`	`295`
	`296`	`+publicfunctiontestSetCodeBindToClosure()`
	`297`	`+ {`
	`298`	`+if (PHP_VERSION_ID <50400) {`
	`299`	`+$this->markTestSkipped('Test skipped, for PHP 5.4+ only.');`
	`300`	`+ }`
	`301`	`+`
	`302`	`+$command =new \TestCommand();`
	`303`	`+$ret =$command->setCode(function (InputInterface$input,OutputInterface$output) {`
	`304`	`+$output->writeln(get_class($this));`
	`305`	`+ });`
	`306`	`+$tester =newCommandTester($command);`
	`307`	`+$tester->execute(array());`
	`308`	`+$this->assertEquals('interact called'.PHP_EOL.'TestCommand'.PHP_EOL,$tester->getDisplay());`
	`309`	`+ }`
	`310`	`+`
`296`	`311`	`publicfunctiontestSetCodeWithNonClosureCallable()`
`297`	`312`	`{`
`298`	`313`	`$command =new \TestCommand();`

Comments

(0)