Commit13a47c3

committed

top-level anonymous services must be public

1 parentaf4ca4f commit13a47c3Copy full SHA for 13a47c3

File tree

-4

lines changed

src/Symfony/Component/DependencyInjection
- Loader
  - XmlFileLoader.php
- Tests/Loader
  - XmlFileLoaderTest.php

-4

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,9 @@ private function processAnonymousServices(SimpleXMLElement $xml, $file)`
`237`	`237`
`238`	`238`	`$definitions[(string)$node['id']] =array($node->service,$file,false);`
`239`	`239`	`$node->service['id'] = (string)$node['id'];`
	`240`	`+`
	`241`	`+// anonymous services are always private`
	`242`	`+$node->service['public'] =false;`
`240`	`243`	`}`
`241`	`244`	`}`
`242`	`245`
`@@ -254,9 +257,6 @@ private function processAnonymousServices(SimpleXMLElement $xml, $file)`
`254`	`257`	`// resolve definitions`
`255`	`258`	`krsort($definitions);`
`256`	`259`	`foreach ($definitionsas$id =>$def) {`
`257`		`-// anonymous services are always private`
`258`		`-$def[0]['public'] =false;`
`259`		`-`
`260`	`260`	`$this->parseDefinition($id,$def[0],$def[1]);`
`261`	`261`
`262`	`262`	`$oNode =dom_import_simplexml($def[0]);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ public function testLoadAnonymousServices()`
`158`	`158`	`$service =$container->getDefinition($id);`
`159`	`159`	`}`
`160`	`160`	`$this->assertEquals('BizClass',$service->getClass(),'->load() uses the same configuration as for the anonymous ones');`
`161`		`-$this->assertFalse($service->isPublic());`
	`161`	`+$this->assertTrue($service->isPublic());`
`162`	`162`
`163`	`163`	`// anonymous services are shared when using decoration definitions`
`164`	`164`	`$container->compile();`

Comments

(0)