Commit105c6f4

committed

[Notifier] [Free Mobile] Could not use custom host in DSN

1 parent3a3b249 commit105c6f4Copy full SHA for 105c6f4

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`*/`
`27`	`27`	`finalclass FreeMobileTransportextends AbstractTransport`
`28`	`28`	`{`
`29`		`-protectedconstHOST ='https://smsapi.free-mobile.fr/sendmsg';`
	`29`	`+protectedconstHOST ='smsapi.free-mobile.fr/sendmsg';`
`30`	`30`
`31`	`31`	`private$login;`
`32`	`32`	`private$password;`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,10 @@ public function create(Dsn $dsn): TransportInterface`
`43`	`43`	`thrownewIncompleteDsnException('Missing phone.',$dsn->getOriginalDsn());`
`44`	`44`	`}`
`45`	`45`
`46`		`-returnnewFreeMobileTransport($login,$password,$phone,$this->client,$this->dispatcher);`
	`46`	`+$host ='default' ===$dsn->getHost() ?null :$dsn->getHost();`
	`47`	`+$port =$dsn->getPort();`
	`48`	`+`
	`49`	`+return (newFreeMobileTransport($login,$password,$phone,$this->client,$this->dispatcher))->setHost($host)->setPort($port);`
`47`	`50`	`}`
`48`	`51`
`49`	`52`	`protectedfunctiongetSupportedSchemes():array`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,7 @@ public function testCreateWithDsn()`
`23`	`23`	`{`
`24`	`24`	`$factory =$this->createFactory();`
`25`	`25`
`26`		`-$dsn ='freemobile://login:pass@default?phone=0611223344';`
`27`		`-$transport =$factory->create(Dsn::fromString($dsn));`
`28`		`-$transport->setHost('host.test');`
	`26`	`+$transport =$factory->create(Dsn::fromString('freemobile://login:pass@host.test?phone=0611223344'));`
`29`	`27`
`30`	`28`	`$this->assertSame('freemobile://host.test?phone=0611223344', (string)$transport);`
`31`	`29`	`}`

Comments

(0)