Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit0c71a93

Browse files
cheacknicolas-grekas
authored andcommitted
Fixed lazy-loading ghost objects generation with property hooks with default values.
1 parente408d54 commit0c71a93

File tree

3 files changed

+23
-7
lines changed

3 files changed

+23
-7
lines changed

‎src/Symfony/Component/VarExporter/ProxyHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public static function generateLazyGhost(\ReflectionClass $class): string
8080
.($p->isProtected() ?'protected' :'public')
8181
.($p->isProtectedSet() ?' protected(set)' :'')
8282
."{$type}\${$name}"
83-
.($p->hasDefaultValue() ?' ='.$p->getDefaultValue() :'')
83+
.($p->hasDefaultValue() ?' ='.VarExporter::export($p->getDefaultValue()) :'')
8484
." {\n";
8585

8686
foreach ($p->getHooks()as$hook =>$method) {

‎src/Symfony/Component/VarExporter/Tests/Fixtures/LazyProxy/HookedWithDefaultValue.php

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,18 @@
44

55
class HookedWithDefaultValue
66
{
7-
publicint$backedWithDefault =321 {
8-
get =>$this->backedWithDefault;
9-
set =>$this->backedWithDefault =$value;
7+
publicint$backedIntWithDefault =321 {
8+
get =>$this->backedIntWithDefault;
9+
set =>$this->backedIntWithDefault =$value;
10+
}
11+
12+
publicstring$backedStringWithDefault ='321' {
13+
get =>$this->backedStringWithDefault;
14+
set =>$this->backedStringWithDefault =$value;
15+
}
16+
17+
publicbool$backedBoolWithDefault =false {
18+
get =>$this->backedBoolWithDefault;
19+
set =>$this->backedBoolWithDefault =$value;
1020
}
1121
}

‎src/Symfony/Component/VarExporter/Tests/LazyGhostTraitTest.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -516,16 +516,22 @@ public function testPropertyHooksWithDefaultValue()
516516
$initialized =true;
517517
});
518518

519-
$this->assertSame(321,$object->backedWithDefault);
519+
$this->assertSame(321,$object->backedIntWithDefault);
520+
$this->assertSame('321',$object->backedStringWithDefault);
521+
$this->assertSame(false,$object->backedBoolWithDefault);
520522
$this->assertTrue($initialized);
521523

522524
$initialized =false;
523525
$object =$this->createLazyGhost(HookedWithDefaultValue::class,function ($instance)use (&$initialized) {
524526
$initialized =true;
525527
});
526-
$object->backedWithDefault =654;
528+
$object->backedIntWithDefault =654;
529+
$object->backedStringWithDefault ='654';
530+
$object->backedBoolWithDefault =true;
527531
$this->assertTrue($initialized);
528-
$this->assertSame(654,$object->backedWithDefault);
532+
$this->assertSame(654,$object->backedIntWithDefault);
533+
$this->assertSame('654',$object->backedStringWithDefault);
534+
$this->assertSame(true,$object->backedBoolWithDefault);
529535
}
530536

531537
/**

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp