Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit091f70c

Browse files
committed
[VarDumper] add DST savings only if useDaylightTime is true
1 parent0f49b16 commit091f70c

File tree

2 files changed

+36
-7
lines changed

2 files changed

+36
-7
lines changed

‎src/Symfony/Component/VarDumper/Caster/IntlCaster.php‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,16 @@ public static function castIntlTimeZone(\IntlTimeZone $c, array $a, Stub $stub,
3939
{
4040
$a +=array(
4141
Caster::PREFIX_VIRTUAL.'display_name' =>$c->getDisplayName(),
42-
Caster::PREFIX_VIRTUAL.'dst_savings' =>$c->getDSTSavings(),
4342
Caster::PREFIX_VIRTUAL.'id' =>$c->getID(),
4443
Caster::PREFIX_VIRTUAL.'raw_offset' =>$c->getRawOffset(),
4544
);
4645

46+
if ($c->useDaylightTime()) {
47+
$a +=array(
48+
Caster::PREFIX_VIRTUAL.'dst_savings' =>$c->getDSTSavings(),
49+
);
50+
}
51+
4752
if ($errorCode =$c->getErrorCode()) {
4853
$a +=array(
4954
Caster::PREFIX_VIRTUAL.'error_code' =>$errorCode,

‎src/Symfony/Component/VarDumper/Tests/Caster/IntlCasterTest.php‎

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,40 @@ public function testArrayIterator()
3434
$this->assertDumpEquals($expected,$var);
3535
}
3636

37-
publicfunctiontestCastIntlTimeZone()
37+
publicfunctiontestCastIntlTimeZoneWithDST()
3838
{
39-
$var = \IntlTimeZone::createTimeZone(1);
39+
$var = \IntlTimeZone::createTimeZone('Europe/Berlin');
40+
41+
$expectedDisplayName =$var->getDisplayName();
42+
$expectedDSTSavings =$var->getDSTSavings();
43+
$expectedID =$var->getID();
44+
$expectedRawOffset =$var->getRawOffset();
45+
46+
$expected =<<<EOTXT
47+
IntlTimeZone {
48+
display_name: "$expectedDisplayName"
49+
id: "$expectedID"
50+
raw_offset:$expectedRawOffset
51+
dst_savings:$expectedDSTSavings
52+
}
53+
EOTXT;
54+
$this->assertDumpEquals($expected,$var);
55+
}
56+
57+
publicfunctiontestCastIntlTimeZoneWithoutDST()
58+
{
59+
$var = \IntlTimeZone::createTimeZone('Asia/Bangkok');
60+
61+
$expectedDisplayName =$var->getDisplayName();
62+
$expectedDSTSavings =$var->getDSTSavings();
63+
$expectedID =$var->getID();
64+
$expectedRawOffset =$var->getRawOffset();
4065

4166
$expected =<<<EOTXT
4267
IntlTimeZone {
43-
display_name: "GMT"
44-
dst_savings: 3600000
45-
id: "Etc/Unknown"
46-
raw_offset: 0
68+
display_name: "$expectedDisplayName"
69+
id: "$expectedID"
70+
raw_offset:$expectedRawOffset
4771
}
4872
EOTXT;
4973
$this->assertDumpEquals($expected,$var);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp