Commit039cd98

committed

[PropertyInfo][Serializer] Fixed extracting ignored properties

1 parent7c31fa0 commit039cd98Copy full SHA for 039cd98

File tree

+42

-1

lines changed

+42

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function getProperties(string $class, array $context = []): ?array`
`47`	`47`	`$serializerClassMetadata =$this->classMetadataFactory->getMetadataFor($class);`
`48`	`48`
`49`	`49`	`foreach ($serializerClassMetadata->getAttributesMetadata()as$serializerAttributeMetadata) {`
`50`		`-$ignored =method_exists($serializerClassMetadata,'isIgnored') &&$serializerAttributeMetadata->isIgnored();`
	`50`	`+$ignored =method_exists($serializerAttributeMetadata,'isIgnored') &&$serializerAttributeMetadata->isIgnored();`
`51`	`51`	`if (!$ignored &&array_intersect($context['serializer_groups'],$serializerAttributeMetadata->getGroups())) {`
`52`	`52`	`$properties[] =$serializerAttributeMetadata->getName();`
`53`	`53`	`}`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,13 @@ public function testGetProperties()`
`40`	`40`	`$this->extractor->getProperties('Symfony\Component\PropertyInfo\Tests\Fixtures\Dummy', ['serializer_groups' => ['a']])`
`41`	`41`	`);`
`42`	`42`	`}`
	`43`	`+`
	`44`	`+publicfunctiontestGetPropertiesWithIgnoredProperties()`
	`45`	`+ {`
	`46`	`+if (!class_exists('Symfony\Component\Serializer\Annotation\Ignore')) {`
	`47`	`+$this->markTestSkipped('Ignore annotation is not implemented in current symfony/serializer version');`
	`48`	`+ }`
	`49`	`+`
	`50`	`+$this->assertSame(['visibleProperty'],$this->extractor->getProperties('Symfony\Component\PropertyInfo\Tests\Fixtures\IgnorePropertyDummy', ['serializer_groups' => ['a']]));`
	`51`	`+ }`
`43`	`52`	`}`

Lines changed: 32 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,32 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+/*`
	`4`	`+ * This file is part of the Symfony package.`
	`5`	`+ *`
	`6`	`+ * (c) Fabien Potencier <fabien@symfony.com>`
	`7`	`+ *`
	`8`	`+ * For the full copyright and license information, please view the LICENSE`
	`9`	`+ * file that was distributed with this source code.`
	`10`	`+ */`
	`11`	`+`
	`12`	`+namespaceSymfony\Component\PropertyInfo\Tests\Fixtures;`
	`13`	`+`
	`14`	`+useSymfony\Component\Serializer\Annotation\Groups;`
	`15`	`+useSymfony\Component\Serializer\Annotation\Ignore;`
	`16`	`+`
	`17`	`+/**`
	`18`	`+ * @author Vadim Borodavko <vadim.borodavko@gmail.com>`
	`19`	`+ */`
	`20`	`+class IgnorePropertyDummy`
	`21`	`+{`
	`22`	`+/**`
	`23`	`+ * @Groups({"a"})`
	`24`	`+ */`
	`25`	`+public$visibleProperty;`
	`26`	`+`
	`27`	`+/**`
	`28`	`+ * @Groups({"a"})`
	`29`	`+ * @Ignore`
	`30`	`+ */`
	`31`	`+private$ignoredProperty;`
	`32`	`+}`

Comments

(0)