Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork57
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:symfony/psr-http-message-bridge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:f16471b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:symfony/psr-http-message-bridge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:03f2f72
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 10commits
- 7files changed
- 7contributors
Commits on Jul 1, 2024
- seriquynh committed
Jul 1, 2024 minor #57610 [PsrHttpMessageBridge] Remove a redundant check in HttpF…
…oundationFactory class (seriquynh)This PR was merged into the 7.2 branch.Discussion----------[PsrHttpMessageBridge] Remove a redundant check in HttpFoundationFactory class| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | N/A| License | MIT`HttpFoundationFactory::createRequest` method receives an implementation of `ServerRequestInterface` and it's `getUri` method must always return a `UriInterface` implementation. So, this check below is redundant.```php<?php$uri = $psrRequest->getUri(); // absolutely is \Psr\Http\Message\UriInterfaceif ($uri instanceof UriInterface) { // redundant check // Do something}```### My ConcernI've checked Symfony roadmap/releases [here](https://symfony.com/releases). And I decided to create a PR to branch 6.4 because:- PsrHttpMessage is included in v6.4 (not in 5.4).- v6.4 is still maintained (v6.0, v6.1, v6.2 and v6.3 are "End of life" versions).- It is not a breaking/major change.Did I choose branch correctly? If not, please give me more references/posts about how to choose a right branch for a PR.Commits-------8e7e208149 Remove redundant checkderrabus committedJul 1, 2024 Remove uniqid() from tempnam() calls
derrabus committedJul 1, 2024
Commits on Jul 6, 2024
updates the remaining tests that were not covered by #57665
xabbuh committedJul 6, 2024
Commits on Aug 15, 2024
* 7.1: [Serializer] Remove redundant@internal tags from traceable classes Fix conversion of partitioned cookies in the PSR-7 bridge [Validator] added Polish translation for units 116-119 Revert stateless check [Console] Fix side-effects from running bash completions skip transient Redis integration tests on AppVeyor
chalasr committedAug 15, 2024
Commits on Sep 25, 2024
* 7.1: Add PR template and auto-close PR on subtree split repositories
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff f16471b...03f2f72
Uh oh!
There was an error while loading.Please reload this page.