Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feature [8.4][bcmath] implement bcround, bcceil and bcfloor#546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Dean151 wants to merge1 commit intosymfony:1.x
base:1.x
Choose a base branch
Loading
fromDean151:feat/bcceil-bcfloor-bcround

Conversation

@Dean151
Copy link

@Dean151Dean151 commentedSep 19, 2025•
edited
Loading

@Dean151Dean151force-pushed thefeat/bcceil-bcfloor-bcround branch 5 times, most recently from394b10a todd5ededCompareSeptember 21, 2025 21:30
@Dean151Dean151 requested a review fromstofSeptember 25, 2025 08:48

if (\PHP_VERSION_ID < 80400) {
// @author Thomas Durand <github@thomasdurand.fr>
final class RoundingMode {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

when PHP >= 8.1 is used, we should use a real enum

Copy link
Author

@Dean151Dean151Oct 16, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas When I try to introduce an enum, even behind an if PHP_VERSION_ID, older PHP version are complaining pretty badly on the syntax.
Seethis CI run
An idea?

@Dean151Dean151force-pushed thefeat/bcceil-bcfloor-bcround branch 3 times, most recently from2f04391 to41c0a15CompareOctober 16, 2025 19:59
@Dean151Dean151force-pushed thefeat/bcceil-bcfloor-bcround branch from41c0a15 to8453863CompareOctober 17, 2025 20:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dean151@nicolas-grekas@stof
[8]ページ先頭
©2009-2025 Movatter.jp