Commita8833c5

Guillaume Pédelagrabe

authored and

committed

[Http Foundation] Fix clear cookie samesite

1 parent13f9b08 commita8833c5Copy full SHA for a8833c5

File tree

+13

-2

lines changed

+13

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -244,10 +244,13 @@ public function getCookies($format = self::COOKIES_FLAT)`
`244`	`244`	`* @param string $domain`
`245`	`245`	`* @param bool $secure`
`246`	`246`	`* @param bool $httpOnly`
	`247`	`+ * @param string $sameSite`
`247`	`248`	`*/`
`248`		`-publicfunctionclearCookie($name,$path ='/',$domain =null,$secure =false,$httpOnly =true)`
	`249`	`+publicfunctionclearCookie($name,$path ='/',$domain =null,$secure =false,$httpOnly =true/, $sameSite = null/)`
`249`	`250`	`{`
`250`		`-$this->setCookie(newCookie($name,null,1,$path,$domain,$secure,$httpOnly));`
	`251`	`+$sameSite =\func_num_args() >5 ?func_get_arg(5) :null;`
	`252`	`+`
	`253`	`+$this->setCookie(newCookie($name,null,1,$path,$domain,$secure,$httpOnly,false,$sameSite));`
`251`	`254`	`}`
`252`	`255`
`253`	`256`	`/**`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,14 @@ public function testClearCookieSecureNotHttpOnly()`
`128`	`128`	`$this->assertSetCookieHeader('foo=deleted; expires='.gmdate('D, d-M-Y H:i:s T',time() -31536001).'; Max-Age=0; path=/; secure',$bag);`
`129`	`129`	`}`
`130`	`130`
	`131`	`+publicfunctiontestClearCookieSamesite()`
	`132`	`+ {`
	`133`	`+$bag =newResponseHeaderBag([]);`
	`134`	`+`
	`135`	`+$bag->clearCookie('foo','/',null,true,false,'none');`
	`136`	`+$this->assertSetCookieHeader('foo=deleted; expires='.gmdate('D, d-M-Y H:i:s T',time() -31536001).'; Max-Age=0; path=/; secure; samesite=none',$bag);`
	`137`	`+ }`
	`138`	`+`
`131`	`139`	`publicfunctiontestReplace()`
`132`	`140`	`{`
`133`	`141`	`$bag =newResponseHeaderBag([]);`

Comments

(0)