Commita7fc7da

committed

feature #29306 [DomCrawler] Optionally use html5-php to parse HTML (tgalopin)

This PR was squashed before being merged into the 4.3-dev branch (closes #29306).Discussion----------[DomCrawler] Optionally use html5-php to parse HTML| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | WIP| Fixed tickets |symfony/symfony#29280,symfony/symfony#28596| License | MIT| Doc PR |symfony/symfony-docs#10700This PR introduces the possibility to parse HTML content in the Crawler using the html5-php library (https://github.com/Masterminds/html5-php). This allows for better support of HTML5 and fix many unexpected behaviors and inconsistencies of the native DOM extension.Commits-------4050ec4257 [DomCrawler] Optionally use html5-php to parse HTML

2 parentsb239386 +89629ce commita7fc7daCopy full SHA for a7fc7da

File tree

1 file changed

-5

lines changed

Tests/Functional/Bundle/TestBundle/Controller
- SessionController.php

1 file changed

-5

lines changed

`‎Tests/Functional/Bundle/TestBundle/Controller/SessionController.php‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,19 +28,19 @@ public function welcomeAction(Request $request, $name = null)`
`28`	`28`	`// new session case`
`29`	`29`	`if (!$session->has('name')) {`
`30`	`30`	`if (!$name) {`
`31`		`-returnnewResponse('You are new here and gave no name.');`
	`31`	`+returnnewResponse('<html><body>You are new here and gave no name.</body></html>');`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`// remember name`
`35`	`35`	`$session->set('name',$name);`
`36`	`36`
`37`		`-returnnewResponse(sprintf('Hello %s, nice to meet you.',$name));`
	`37`	`+returnnewResponse(sprintf('<html><body>Hello %s, nice to meet you.</body></html>',$name));`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`// existing session`
`41`	`41`	`$name =$session->get('name');`
`42`	`42`
`43`		`-returnnewResponse(sprintf('Welcome back %s, nice to meet you.',$name));`
	`43`	`+returnnewResponse(sprintf('<html><body>Welcome back %s, nice to meet you.</body></html>',$name));`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`publicfunctioncacheableAction()`
`@@ -55,7 +55,7 @@ public function logoutAction(Request $request)`
`55`	`55`	`{`
`56`	`56`	`$request->getSession()->invalidate();`
`57`	`57`
`58`		`-returnnewResponse('Session cleared.');`
	`58`	`+returnnewResponse('<html><body>Session cleared.</body></html>');`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`publicfunctionsetFlashAction(Request$request,$message)`
`@@ -76,6 +76,6 @@ public function showFlashAction(Request $request)`
`76`	`76`	`$output ='No flash was set.';`
`77`	`77`	`}`
`78`	`78`
`79`		`-returnnewResponse($output);`
	`79`	`+returnnewResponse('<html><body>'.$output.'</body></html>');`
`80`	`80`	`}`
`81`	`81`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commita7fc7da

File tree

1 file changed

1 file changed

`‎Tests/Functional/Bundle/TestBundle/Controller/SessionController.php‎`

0 commit comments