Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork266
Comparing changes
Open a pull request
base repository:symfony/console
Uh oh!
There was an error while loading.Please reload this page.
base:v6.4.12
head repository:symfony/console
Uh oh!
There was an error while loading.Please reload this page.
compare:v6.4.22
- 20commits
- 11files changed
- 8contributors
Commits on Sep 25, 2024
Tweak error/exception handler registration
nicolas-grekas committedSep 25, 2024 * 5.4: Tweak error/exception handler registration
nicolas-grekas committedSep 25, 2024 minor #58355 Add PR template and auto-close PR on subtree split repos…
…itories (GromNaN)This PR was squashed before being merged into the 5.4 branch.Discussion----------Add PR template and auto-close PR on subtree split repositories| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | Fix #57267| License | MITExtract the Pull Request Template from #54653.~The GitHub action did not work as said by `@nicolas`-grekassymfony/symfony#57267 (comment) Replaced byhttps://github.com/superbrothers/close-pull-request.Commits-------d90fa7ab08f Add PR template and auto-close PR on subtree split repositories
nicolas-grekas committedSep 25, 2024 * 5.4: Add PR template and auto-close PR on subtree split repositories
nicolas-grekas committedSep 25, 2024
Commits on Sep 28, 2024
bug #58332 [Console] Suppress
proc_openerrors within `Terminal::re……adFromProcess` (fritzmg)This PR was merged into the 5.4 branch.Discussion----------[Console] Suppress `proc_open` errors within `Terminal::readFromProcess`| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues || License | MITWhen instantiating `SymfonyStyle` in a command it will try to determine the maximum width of the current console interface.https://github.com/symfony/symfony/blob/6687e4ea35f45ebd73fb0315938103628cfb13a0/src/Symfony/Component/Console/Style/SymfonyStyle.php#L53This will execute `stty -a | grep columns` down the line. Access to `stty` might be disallowed however, resulting in the following error:```ErrorException: Warning: proc_open(): Exec failed: Permission denied#16 /vendor/symfony/console/Terminal.php(220): Symfony\Component\Console\Terminal::readFromProcess#15 /vendor/symfony/console/Terminal.php(204): Symfony\Component\Console\Terminal::getSttyColumns#14 /vendor/symfony/console/Terminal.php(170): Symfony\Component\Console\Terminal::initDimensionsUsingStty#13 /vendor/symfony/console/Terminal.php(153): Symfony\Component\Console\Terminal::initDimensions#12 /vendor/symfony/console/Terminal.php(94): Symfony\Component\Console\Terminal::getWidth#11 /vendor/symfony/console/Style/SymfonyStyle.php(55): Symfony\Component\Console\Style\SymfonyStyle::__construct#10 /vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(136): Symfony\Component\Messenger\Command\ConsumeMessagesCommand::interact#9 /vendor/symfony/console/Command/Command.php(311): Symfony\Component\Console\Command\Command::run```(Stack Trace actually from Symfony 6)The phpDoc of `Terminal::getSttyColumns` states> Runs and parses stty -a if it's available, _suppressing any error output_.The latter might refer to `['suppress_errors' => true]` (though I am not sure) - which is a Windows only functionality. In any case, since `Terminal::readFromProcess` already checks for```phpif (!$process = proc_open(…)) { return null;}```and```phpif (!\is_resource($process)) { return null;}```upstream in Symfony 6/7, indicating that `proc_open` might fail - this error can additionally be suppressed using `@`. Besides, `Process::start` also uses ``@proc_open`` (added insymfony/symfony@099481f "Prevent warning in proc_open()").Commits-------575249a3431 suppress proc_open errors
nicolas-grekas committedSep 28, 2024 * 5.4: Add missing Albanian translations for Security and Validator components suppress proc_open errors [DependencyInjection] Fix `XmlFileLoader` not respecting when env for services
xabbuh committedSep 28, 2024
Commits on Oct 8, 2024
minor #58472 CS: clean some whitespaces/indentation (keradus)
This PR was squashed before being merged into the 7.2 branch.Discussion----------CS: clean some whitespaces/indentation| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | Fix CS| License | MITCommits-------d0f63b8afa1 CS: clean some whitespaces/indentation
nicolas-grekas committedOct 8, 2024
Commits on Oct 9, 2024
* 5.4: minor #58472 CS: clean some whitespaces/indentation (keradus) Fix newline harden test to not depend on the system's configured default timezone [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer [ExpressionLanguage] Add missing test case for `Lexer` [FrameworkBundle] Fix passing request_stack to session.listener ensure session storages are opened in tests before destroying them [HttpKernel] Correctly merge `max-age`/`s-maxage` and `Expires` headers [Security][Validator] Check translations for Czech [Security] Fix serialized object representation in tests [DoctrineBridge] Fix risky test warnings
xabbuh committedOct 9, 2024
Commits on Nov 5, 2024
fix detecting anonymous exception classes on Windows and PHP 7
xabbuh committedNov 5, 2024 * 5.4: fix detecting anonymous exception classes on Windows and PHP 7 skip tests requiring the intl extension if it's not installed [RateLimiter] Fix DateInterval normalization [Security] Store original token in token storage when implicitly exiting impersonation [Cache] Fix clear() when using Predis
nicolas-grekas committedNov 5, 2024
Commits on Nov 6, 2024
skip autocomplete test when stty is not available
xabbuh committedNov 6, 2024 * 5.4: Port Appveyor to GitHub Actions normalize paths to avoid failures if a path is referenced by different names skip autocomplete test when stty is not available Bump Symfony version to 5.4.47 Update VERSION for 5.4.46 Update CONTRIBUTORS for 5.4.46 Update CHANGELOG for 5.4.46
nicolas-grekas committedNov 6, 2024
Commits on Mar 3, 2025
fix(console): fix progress bar messing output in section when there i…
…s an EOL
joelwurtz committedMar 3, 2025
Commits on May 6, 2025
don't hardcode OS-depending constant values
The values of the SIG* constants depend on the OS.
xabbuh committedMay 6, 2025
Commits on May 7, 2025
properly skip signal test if the pcntl extension is not installed
xabbuh committedMay 7, 2025
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v6.4.12...v6.4.22
Uh oh!
There was an error while loading.Please reload this page.