NotificationsYou must be signed in to change notification settings
Fork57
Star807

BridgeJS: Fix nested type resolution for MemberTypeSyntax (e.g., Networking.API.Method)#433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kateinoigakukun merged 1 commit intoswiftwasm:mainfromPassiveLogic:fix/nested-enum-methods-fix

Aug 26, 2025

Merged

BridgeJS: Fix nested type resolution for MemberTypeSyntax (e.g., Networking.API.Method)#433

kateinoigakukun merged 1 commit intoswiftwasm:mainfromPassiveLogic:fix/nested-enum-methods-fix

Aug 26, 2025

Conversation

Copy link

Member

krodak commentedAug 26, 2025

Issue

Currently for functions that would be using nested types like:

@JSfunc echoNetworkingAPIMethod(_ method:Networking.API.Method)->Networking.API.Method{…}

We'd get following error:

error: Unsupported type: Networking.API.MethodHint: Only primitive types and types defined in the same module are allowed

Issue is that currentlylookupType(for only handlesIdentifierTypeSyntax, henceMemberTypeSyntax likeNetworking.API.Method would not be resolved to a valid declaration.

Fix

Centralized type resolution inTypeDeclResolver with a newresolve(_: TypeSyntax) API and used it inExportSwift to map nested enums/classes/actors toBridgeType. This should help with nested types resolution, while exported ABI remains unchanged for already-supported types.
New tests were added toprelude.mjs to confirm the fix.