Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork57
BridgeJS: Improve Xcode editing experience by removing symlinks#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Xcode does not handle symlinks well, especially when showing errorsin the editor. This commit removes the symlinks in the BridgeJSplugin package and use SwiftPM's native target structure.We still use symlinks for the actual BridgeJSTool executable targetin the main package as a build-time optimization, but it should notaffect the Xcode editing experience on the main package.
8bf1e9e tof5d74deCompare635daa6 intomain 8 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode does not handle symlinks well, especially when showing errors in the editor. This commit removes the symlinks in the BridgeJS plugin package and use SwiftPM's native target structure. We still use symlinks for the actual BridgeJSTool executable target in the main package as a build-time optimization, but it should not affect the Xcode editing experience on the main package.