Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reapply "FixJSClosure leak (#240)"#242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
kateinoigakukun wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromreapply-closure-leak-fix

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukunkateinoigakukun commentedApr 12, 2024
edited
Loading

Seems like something wrong is happening inhttps://github.com/swiftwasm/JavaScriptKit/actions/runs/8659623850. I need stress test this before re-landing this.

This reverts commit8780e5f.

omochi reacted with eyes emoji
@kateinoigakukunkateinoigakukun marked this pull request as draftApril 12, 2024 09:22
@github-actionsGitHub Actions
Copy link

Time Change: +114ms (1%)

Total Time: 9,319ms

Test nameDurationChange
Serialization/JavaScript function call through Wasm import19ms-4ms (19%)👏
View Unchanged
Test nameDurationChange
Serialization/JavaScript function call through Wasm import with int15ms-1ms
Serialization/JavaScript function call from Swift99ms+2ms (1%)
Serialization/Swift Int to JavaScript with assignment330ms+9ms (2%)
Serialization/Swift Int to JavaScript with call939ms+8ms (0%)
Serialization/JavaScript Number to Swift Int303ms-1ms
Serialization/Swift String to JavaScript with assignment383ms-0ms
Serialization/Swift String to JavaScript with call976ms-7ms (0%)
Serialization/JavaScript String to Swift String3,622ms+96ms (2%)
Object heap/Increment and decrement RC2,620ms+12ms (0%)
View Baselines
Test nameDuration
Serialization/Call JavaScript function directly3ms
Serialization/Assign JavaScript number directly2ms
Serialization/Call with JavaScript number directly3ms
Serialization/Write JavaScript string directly3ms
Serialization/Call with JavaScript string directly2ms

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@kateinoigakukun

[8]ページ先頭

©2009-2025 Movatter.jp