Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve the ergonomics of working with theSymbol.Availability.Domain constants#90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
d-ronnqvist wants to merge1 commit intoswiftlang:main
base:main
Choose a base branch
Loading
fromd-ronnqvist:domain-ergonomics

Conversation

@d-ronnqvist
Copy link
Contributor

Bug/issue #, if applicable:

Summary

This improves the ergonomics of creatingSymbol.Availability.Domain values for known constants.

Currently, because the constants are string values, creating a domain value for a known domain looks like:

letdomain=Symbol.Availability.Domain(rawValue:Symbol.Availability.Domain.macOS)

with these changes, creating the same domain value looks like:

letdomain=Symbol.Availability.Domain.macOS

Warning

This is an API breaking change

I tried to avoid making API breaking changes here but I didn't really like any of the alternatives. The least bad workaround I could think of was:

publicstaticletswiftDomain=Domain(rawValue:"Swift")@available(*, deprecated, renamed:"swiftDomain", message:"Use 'swiftDomain' instead. This deprecated API will be removed after 6.2 is released")publicstaticletswift="Swift"

What I don't like about it is that after the 6.2 release we're either going to have API that doesn't follow Swift's API Design Guidelines (because it repeats the type name in the property name) or we're going to have to deprecate it again to rename it back to just "swift".

I have some hopes that this API is nearly unused in practice because the current ergonomics are so bad that I'd expect that someone would have complained about it if anyone was using it.

Dependencies

This doesn't depend on anything but it's a breaking change for other repos.

Testing

Nothing in particular. This isn't a user-facing change.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the./bin/test script and it succeeded
  • Updated documentation if necessary

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@d-ronnqvist

[8]ページ先頭

©2009-2025 Movatter.jp