- Notifications
You must be signed in to change notification settings - Fork10.6k
Sema: SuppressedAssociatedTypesWithDefaults#85704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kavon wants to merge2 commits intoswiftlang:mainChoose a base branch fromkavon:suppressed-assoc-types-with-defaults
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There's about to be a second version that I'd like totest in parallel with the old version.
This is similar to SuppressedAssociatedTypes, but infersdefault requirements when primary associated types ofprotocols are suppressed. This defaulting for the primaryassociated types happens in extensions of the protocol,along with generic parameters, whenever a source-writtenrequirement states a conformance requirement for the protocol.Thus, the current scheme for this defaulting is a simplistic,driven by source-written requirements, rather than factsthat are inferred while building generic signatures.Defaults are not expanded for infinitely many associated types.Other changes include...Sema: adjust protocol extension signature hackWith SuppressedAssociatedTypesWithDefaults,we can have associated types that are missinginvertible conformance requirements, so we needto try re-building the signature for the extensionof the protocol. Otherwise, we won't infer the newdefault(s) for those associated types.This previous hack was only trying to shortcutthe rebuilding if it saw Self is lacking a conformancerequirement. Now it'll check if any inverses were writtenin source for that protocol.
7a739ba toc486f40CompareMemberAuthor
kavon commentedNov 25, 2025
@swift-ci test |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.