- Notifications
You must be signed in to change notification settings - Fork10.5k
[stdlib] GeneralizeArray(unsafeUninitializedCapacity:initializingWith:) for typed throws#83160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
@swift-ci please benchmark |
@swift-ci please Apple Silicon benchmark |
@swift-ci please smoke test |
| PRESPEC_SYMBOL($sSa28_unsafeUninitializedCapacity16initializingWithSayxGSi_ySryxGz_SiztKXEtKcfCs6UInt16V_Tg5) | ||
| PRESPEC_SYMBOL($sSa28_unsafeUninitializedCapacity16initializingWithSayxGSi_ySryxGz_SiztKXEtKcfCs6UInt32V_Tg5) | ||
| PRESPEC_SYMBOL($sSa28_unsafeUninitializedCapacity16initializingWithSayxGSi_ySryxGz_SiztKXEtKcfCs6UInt64V_Tg5) | ||
| PRESPEC_SYMBOL($sSa28_unsafeUninitializedCapacity16initializingWithSayxGSi_ySryxGz_SiztKXEtKcfCs7UnicodeO6ScalarV_Tg5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't removing these symbols from libswiftSwiftOnoneSupport an ABI break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes it is; I wanted to see whether it shows up in benchmarks, thus the PR.
I haven't been able to make the prespecialization work with the modified symbols, though.
@swift-ci please smoke test macOS platform |
Array(unsafeUninitializedCapacity:initializingWith:)(fromSE-0245) had not yet been generalized for typed throws.This does so, making the generalized version an
@_alwaysEmitIntoClientfunction.This also makes the prespecializations performed by SwiftOnoneSupport unnecessary.