NotificationsYou must be signed in to change notification settings
Fork10.6k
Star69.4k

[6.0][Availability] Diagnose unavailable conformances in`UnderlyingToOpaqueExpr`.#73697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hborla merged 1 commit intoswiftlang:release/6.0fromhborla:6.0-opaque-type-conformance-availability

May 17, 2024

Merged

[6.0][Availability] Diagnose unavailable conformances in`UnderlyingToOpaqueExpr`.#73697

hborla merged 1 commit intoswiftlang:release/6.0fromhborla:6.0-opaque-type-conformance-availability

May 17, 2024

Conversation

Copy link

Member

hborla commentedMay 17, 2024•
edited
Loading

Explanation: The compiler was not diagnosing unavailable conformances used for opaque result types. This changes the availability checker to check substitution maps of underlying values for opaque result types to diagnose unavailable conformances. This change also makes sureSendable availability diagnostics are errors in Swift 6 mode.
Scope: Impacts opaque result types whose underlying types have unavailable conformances or missingSendable conformances.
Issue: rdar://125421098,Opaque return type sendability checking hole #72926
Risk: Low. This could cause some miscompiling code to fail to build, but the most likely case of code violating these rules is forSendable, which is staged in as a warning until Swift 6 mode.
Testing: Added new tests.
Reviewer:@slavapestov @tshortli
Main branch PR:[Availability] Diagnose unavailable conformances inUnderlyingToOpaqueExpr. #73695

[Availability] Diagnose unavailable conformances in UnderlyingToOpaqu…

b35e4a6

…eExpr.Change the availability checker to check substitution maps of underlyingvalues for opaque result types to diagnose unavailable conformances. Thischange also makes sure `Sendable` availability diagnostics are errors inSwift 6 mode.(cherry picked from commit1ec5808)