- Notifications
You must be signed in to change notification settings - Fork136
enable StrictConcurrency build setting#760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Lukasa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is currently incompatible with warnings-as-errors, so we need some CI tweaks to handle it.
weissi commentedAug 7, 2024
Ah yeah, should I just tweak the CI? |
| test: | ||
| <<:*common | ||
| command:/bin/bash -xcl "swift test --parallel -Xswiftc -warnings-as-errors --enable-test-discovery $${SANITIZER_ARG-} $${IMPORT_CHECK_ARG-}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Lukasa removed that
Lukasa commentedAug 7, 2024
That can work, though@FranzBusch is in the process of cutting over to a new CI scheme so we may want to hold off and tackle this slightly later. It's also not clear that AHC can easily do this without us sorting out NIO first. |
Set
so we know where there's work.