- Notifications
You must be signed in to change notification settings - Fork136
Fix race between connection close and scheduling new request#546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Lukasa merged 1 commit intoswift-server:mainfromfabianfett:ff-fix-race-close-vs-next-requestJan 24, 2022
Merged
Fix race between connection close and scheduling new request#546
Lukasa merged 1 commit intoswift-server:mainfromfabianfett:ff-fix-race-close-vs-next-requestJan 24, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
weissi approved these changesJan 24, 2022
Contributor
weissi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thank you!
Lukasa approved these changesJan 24, 2022
fabianfett added a commit to fabianfett/async-http-client that referenced this pull requestJan 24, 2022
dnadoba pushed a commit that referenced this pull requestJan 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We may have a race condition between scheduling a request on an http/1.1 connection and the connection being closed.
Changes
Result
We don't crash anymore.