This pull request introduces a newtext property to theAxisX andAxisY components, enabling users to toggle tick labels on or off. The changes improve flexibility in axis customization and include updates to related helper components, examples, and tests.

Examples and Documentation:

Added anew example showcasing how to use thetext property to create minor tick lines without labels.

Testing Improvements:

Added a test case to validate the behavior of thetext property inAxisX, ensuring tick labels are omitted whentext is set tonull.

feat: allow disabling of axis labels using text={false} or text={null}

c206e58

gka requested a review fromCopilot

May 29, 2025 11:42

Copy link

netlifybot commentedMay 29, 2025•
edited
Loading

✅ Deploy Preview forsvelteplot ready!

Name	Link
🔨 Latest commit	`dead08e`
🔍 Latest deploy log	https://app.netlify.com/projects/svelteplot/deploys/68384ade14bf3d0008f82467
😎 Deploy Preview	https://deploy-preview-95--svelteplot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

CopilotAI reviewed

May 29, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds a newtext prop toAxisX andAxisY to allow disabling tick labels, updates internal helpers to respect this flag, and provides examples and tests illustrating the feature.

Introducetext prop inAxisX,AxisY, and their base helpers.
Wrap label rendering inBaseAxisX.svelte andBaseAxisY.svelte withif (text) guards.
Add a Svelte example (major-minor.svelte) and a unit test forAxisX.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/lib/marks/helpers/BaseAxisX.svelte	Added`text` prop and conditional label rendering (plus leftover debug).
src/lib/marks/helpers/BaseAxisY.svelte	Added`text` prop and wrapped label loops in`if (text)`.
src/lib/marks/AxisX.svelte	Exposed`text` prop to the base helper.
src/lib/marks/AxisY.svelte	Exposed`text` prop to the base helper.
src/tests/axisX.test.ts	New test verifying labels are omitted when`text` is`null`.
src/routes/examples/axis/major-minor.svelte	Example showing major and minor ticks with labels disabled.

fix test, remove inspect

aaf5010

gka temporarily deployed to npm

May 29, 2025 11:50

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedMay 29, 2025

📦 Preview package for this PR is published!

Version:0.2.9-pr-95.0

Install it with:

npm install svelteplot@pr-95# or install the specific versionnpm install svelteplot@0.2.9-pr-95.0

screenshots

dead08e

gka temporarily deployed to npm

May 29, 2025 11:54

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedMay 29, 2025

📦 Preview package for this PR is published!

Version:0.2.9-pr-95.1

Install it with:

npm install svelteplot@pr-95# or install the specific versionnpm install svelteplot@0.2.9-pr-95.1

gka merged commite46635d intomain

May 29, 2025

8 checks passed

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: allow disabling of axis labels using text={false} or text={null}#95

feat: allow disabling of axis labels using text={false} or text={null}#95

Uh oh!

Conversation

gka commentedMay 29, 2025•
edited
Loading