Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for "unit stacking"#105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gka merged 22 commits intomainfromfix/stacked-unit-chart
Sep 19, 2025
Merged

Conversation

@gka
Copy link
Contributor

@gkagka commentedJun 2, 2025
edited
Loading

resolves#102

This pull request introduces several improvements and bug fixes across the transforms, marks, and helpers in the codebase, focusing on more robust stacking, sorting, and recordizing logic. The most significant changes are enhancements to the stacking transforms with more comprehensive tests, improved sorting behavior for strings and dates, and better handling of raw value arrays in recordizing functions.

Transform logic improvements

  • Refactored the stacking logic instack.ts to handle both grouped and unit stacking, ensuring series identities remain consistent and supporting more stacking modes. Added support for facet stacking and improved handling of raw value arrays.[1][2][3]
  • Added extensive new tests forstackY andstackX transforms, covering basic, centered, normalized, facet, unit, and recordized array stacking scenarios.

Sorting enhancements

  • Improved thesort transform to handle string and date sorting correctly usinglocaleCompare for strings and numeric comparison for dates. Also, non-finite sort values are mapped toInfinity to avoid sort errors.
  • Updated sort tests to cover sorting by string and date channels, and refactored test data for broader coverage.[1][2][3]

Recordizing and accessor fixes

  • ModifiedrecordizeX andrecordizeY to exclude irrelevant channels (x,x1,x2 ory,y1,y2) when the input data is a raw value array, preventing channel pollution and improving downstream transforms.[1][2]
  • UpdatedresolveProp to use a more robust check for the presence ofRAW_VALUE on a datum, improving type safety.

Mark and formatting tweaks

  • Changed number formatting inPlot.svelte andColorLegend.svelte for more compact and grouped number display, improving chart readability.[1][2]
  • UpdatedAreaY.svelte to import required constants and functions for improved mark rendering.

moritzleidinger reacted with heart emoji
@netlify
Copy link

netlifybot commentedJun 2, 2025
edited
Loading

Deploy Preview forsvelteplot failed.

NameLink
🔨 Latest commit7dd8285
🔍 Latest deploy loghttps://app.netlify.com/projects/svelteplot/deploys/684be5a11898a20008a1bd55

@gkagkaforce-pushed thefix/stacked-unit-chart branch from07f7c07 to7dd8285CompareJune 13, 2025 08:47
@netlify
Copy link

netlifybot commentedSep 16, 2025
edited
Loading

Deploy Preview forsvelteplot ready!

NameLink
🔨 Latest commite2d384b
🔍 Latest deploy loghttps://app.netlify.com/projects/svelteplot/deploys/68cd619da1a7a40009f36026
😎 Deploy Previewhttps://deploy-preview-105--svelteplot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@gkagkaforce-pushed thefix/stacked-unit-chart branch fromde43fa3 to78482e2CompareSeptember 16, 2025 06:58
@gkagkaforce-pushed thefix/stacked-unit-chart branch from78482e2 tobee49a6CompareSeptember 16, 2025 06:58
@gkagka changed the titledocs: add stacked unit chart examplefeat: add support for "unit stacking"Sep 19, 2025
@gkagka marked this pull request as ready for reviewSeptember 19, 2025 12:45
@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.4.4-pr-105.0

Install it with:

npm install svelteplot@pr-105# or install the specific versionnpm install svelteplot@0.4.4-pr-105.0
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.4.4-pr-105.1

Install it with:

npm install svelteplot@pr-105# or install the specific versionnpm install svelteplot@0.4.4-pr-105.1
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.4.4-pr-105.2

Install it with:

npm install svelteplot@pr-105# or install the specific versionnpm install svelteplot@0.4.4-pr-105.2
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@gkagka merged commit3961bb6 intomainSep 19, 2025
8 checks passed
@gkagka deleted the fix/stacked-unit-chart branchSeptember 19, 2025 14:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] can't render stacked unit chart

2 participants

@gka

[8]ページ先頭

©2009-2025 Movatter.jp