Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork21
Fix/use unknown color#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedMay 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forsvelteplot ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.0 |
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.1 |
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.2 |
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.3 |
8e106d5 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
resolves#100
unknowncolor value (#cccccc99) for invalid data, ensuring better visual distinction in plots. (src/lib/core/Plot.svelte,[1][2]Mark.svelteto improve handling of invalid data points. (src/lib/Mark.svelte,src/lib/Mark.svelteL261-R271)Dotmarks from "dots" to "dot" for better consistency. (src/lib/marks/Dot.svelte,src/lib/marks/Dot.svelteL87-R86)Examples and Documentation:
Dotmarks. (src/routes/examples/dot/bubble-matrix.svelte,src/routes/examples/dot/bubble-matrix.svelteR1-R27)src/routes/+page.md,src/routes/+page.mdL8-R15)Testing Infrastructure Updates:
New Tests:
Dotmarks, validating rendering, scaling, and color mapping based on data. (src/tests/dot.test.svelte,[1];src/tests/dot.test.ts,[2]Utility Functions:
getRectDims,getPathDims,getTranslate) for extracting dimensions and transformations from SVG elements, improving test reliability and modularity. (src/tests/utils.ts,src/tests/utils.tsR1-R40)BarXtests to replace inline dimension calculation functions with the new utility functions. (src/tests/barX.test.ts,[1][2]Code Quality Improvements:
ESLint Configuration:
console.logwhile permittingconsole.error. (eslint.config.js,eslint.config.jsR6-R16)svelte/no-inspectrule to warn against using the inspect directive in Svelte files. (eslint.config.js,eslint.config.jsR6-R16)Refactoring:
updateMark,updatePlotState) fromMark.svelteto streamline the codebase. (src/lib/Mark.svelte,src/lib/Mark.svelteL59-R59)ColorLegendstyling to include column gaps for better spacing. (src/lib/marks/ColorLegend.svelte,src/lib/marks/ColorLegend.svelteR170)