Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix/use unknown color#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gka merged 23 commits intomainfromfix/use-unknown-color
May 31, 2025
Merged

Fix/use unknown color#104

gka merged 23 commits intomainfromfix/use-unknown-color
May 31, 2025

Conversation

@gka
Copy link
Contributor

@gkagka commentedMay 30, 2025
edited
Loading

resolves#100

  • Updated the handling of color scales to use a newunknown color value (#cccccc99) for invalid data, ensuring better visual distinction in plots. (src/lib/core/Plot.svelte,[1][2]
  • Adjusted the logic for validating color scale values inMark.svelte to improve handling of invalid data points. (src/lib/Mark.svelte,src/lib/Mark.svelteL261-R271)
  • Changed the default class name forDot marks from "dots" to "dot" for better consistency. (src/lib/marks/Dot.svelte,src/lib/marks/Dot.svelteL87-R86)

Examples and Documentation:

Testing Infrastructure Updates:

New Tests:

  • Introduced a dedicated test forDot marks, validating rendering, scaling, and color mapping based on data. (src/tests/dot.test.svelte,[1];src/tests/dot.test.ts,[2]

Utility Functions:

  • Added reusable utility functions (getRectDims,getPathDims,getTranslate) for extracting dimensions and transformations from SVG elements, improving test reliability and modularity. (src/tests/utils.ts,src/tests/utils.tsR1-R40)
  • Refactored existingBarX tests to replace inline dimension calculation functions with the new utility functions. (src/tests/barX.test.ts,[1][2]

Code Quality Improvements:

ESLint Configuration:

  • Added a new rule to disallowconsole.log while permittingconsole.error. (eslint.config.js,eslint.config.jsR6-R16)
  • Introduced thesvelte/no-inspect rule to warn against using the inspect directive in Svelte files. (eslint.config.js,eslint.config.jsR6-R16)

Refactoring:

@netlify
Copy link

netlifybot commentedMay 30, 2025
edited
Loading

Deploy Preview forsvelteplot ready!

NameLink
🔨 Latest commit205cd38
🔍 Latest deploy loghttps://app.netlify.com/projects/svelteplot/deploys/683b93bed99da500087844be
😎 Deploy Previewhttps://deploy-preview-104--svelteplot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.2.9-pr-104.0

Install it with:

npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.0
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.2.9-pr-104.1

Install it with:

npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.1
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.2.9-pr-104.2

Install it with:

npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.2
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@github-actions
Copy link

📦 Preview package for this PR is published!

Version:0.2.9-pr-104.3

Install it with:

npm install svelteplot@pr-104# or install the specific versionnpm install svelteplot@0.2.9-pr-104.3
github-actions[bot] reacted with thumbs up emojigithub-actions[bot] reacted with rocket emoji

@gkagka merged commit8e106d5 intomainMay 31, 2025
7 of 8 checks passed
@gkagka deleted the fix/use-unknown-color branchMay 31, 2025 23:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Grouping by x, y, and stroke doesn't work

2 participants

@gka

[8]ページ先頭

©2009-2025 Movatter.jp