Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork164
docs: Addtwoslash-svelte
#955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedDec 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
@Hugos68 is attempting to deploy a commit to theSvelte Team onVercel. A member of the Team first needs toauthorize it. |
Thank you! It looks like line 689 needs updating... -} else if (language === 'js' || language === 'ts') {+} else if (language === 'js' || language === 'ts' || language === 'svelte') { ...along with line 700: -lang: 'ts',+lang: language === 'svelte' ? language : 'ts', Though when I make those changes locally, I start seeing errors like this which I I don't really understand 😆 maybe@dummdidumm can make sense of them:
|
Hugos68 commentedDec 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ahh, these are expected! That meanssomething is working, thanks for checking it out, I'll make your changes and continue working on it. I do have to see the Svelte docs rendered is quite the module. Lots of stuff going on. |
Uh oh!
There was an error while loading.Please reload this page.
A note on documentation PRs
Closes#649
This PR replaced the
twoslash
withtwoslash-svelte
package to allow type hints to be available onsvelte
codeblocks.Note:
Currently this PR installs the
@hugokorte/twoslash-svelte
PR, this is because the original/officialtwoslash-svelte
package won't be published untilThis PR is merged. The code is simply a copy and published seperately.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.