Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: move DB stuff over from sites repo#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
benmccann wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromdb
Open

Conversation

benmccann
Copy link
Member

ref#536. and also mentioned by french translation folks

Am I correct in assuming this should move here and is still used by the new site?

@vercelVercel
Copy link

vercelbot commentedOct 24, 2024
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
kit-svelte-dev🔄 Building (Inspect)Visit Preview💬Add feedbackApr 4, 2025 7:49pm
learn-svelte-dev✅ Ready (Inspect)Visit Preview💬Add feedbackApr 4, 2025 7:49pm
omnisite✅ Ready (Inspect)Visit Preview💬Add feedbackApr 4, 2025 7:49pm
svelte-5-preview✅ Ready (Inspect)Visit Preview💬Add feedbackApr 4, 2025 7:49pm
svelte-dev✅ Ready (Inspect)Visit Preview💬Add feedbackApr 4, 2025 7:49pm

@dummdidumm
Copy link
Member

Should we put this stuff inside a bigcontributing.md file?

bleucitron reacted with thumbs up emoji

@Rich-Harris
Copy link
Member

Feels like this should go inapps/svelte.dev, no?

Are these instructions sufficient? Presumably you also need a GitHub app set up for auth, otherwise you can't save to the db anyway

@benmccann
Copy link
MemberAuthor

Should we put this stuff inside a big contributing.md file?

Done

Feels like this should go in apps/svelte.dev, no?

Done

Are these instructions sufficient? Presumably you also need a GitHub app set up for auth, otherwise you can't save to the db anyway

No idea. There's at least less missing parts now than before. But I don't really have this stuff setup or know enough to document it fully

@Rich-Harris
Copy link
Member

I don't think there's much point merging a PR until we've validated that it works

@benmccann
Copy link
MemberAuthor

My main concern was trying to cleanup the sites repo without losing anything

@SrGeneroso
Copy link

would be possible to add the playground as an iframe from svelte.dev so the translation sites doesn't have to host their own db?
Since the playground (can i keep calling it repl?) need the github auth and a separate db I think that would fragmentate userbase. Would be nice to have all the users in the same db. Would that be very complicated?
https://sveltefr.dev/playground/hello-world?version=5.1.3

@Rich-Harris
Copy link
Member

Stuff like this is why we'd prefer to internationalise svelte.dev than have a bunch of different sites with translations

SrGeneroso reacted with heart emoji

@benmccann
Copy link
MemberAuthor

I deleted all files from the sites repo except for the HN example, so these files only live here. It is impossible for me to do anything else in this PR because I don't know what the rest of the setup steps are, so I can't document them. I'd be happy if someone would like to complete this PR. Otherwise, I think this is still worth merging as some help is better than none and folks aren't going to know to look in the PR queue to find the files that are necessary to setup the DB

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@benmccann@dummdidumm@Rich-Harris@SrGeneroso

[8]ページ先頭

©2009-2025 Movatter.jp