sveltejs/svelte-eslint-parserPublic

NotificationsYou must be signed in to change notification settings
Fork23
Star109

feat: async Svelte#725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ota-meshi merged 9 commits intomainfromfeat/async

Jul 16, 2025

Merged

feat: async Svelte#725

ota-meshi merged 9 commits intomainfromfeat/async

Jul 16, 2025

+22,996 −42

Conversation

Copy link

Member

baseballyama commentedJul 15, 2025•
edited
Loading

follow:sveltejs/svelte#15844,sveltejs/svelte#16376,sveltejs/svelte#16379

feat: support .pending

bcf55e8

Copy link

changeset-botbot commentedJul 15, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:003653c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte-eslint-parser	Minor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

fix: add AttachTag to Child

7b7e8ef

Copy link

Contributor

github-actionsbot commentedJul 16, 2025•
edited
Loading

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@003653c

Published Instant Preview Packages:

svelte-eslint-parser:https://pkg.pr.new/svelte-eslint-parser@003653c

View Commit

baseballyama added4 commits

July 16, 2025 10:34

fix: type

85c1426

wip: add tests and allow top level await

5751ee7

fix (wip)

e96c12b

fix

d3f638a

Copy link

coveralls commentedJul 16, 2025•
edited
Loading

Pull Request Test Coverage Report forBuild 16318899654

Details

11 of11(100.0%) changed or added relevant lines in3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at94.705%

Totals
Change from baseBuild 15091829763:	0.0%
Covered Lines:	10558
Relevant Lines:	11025

💛 -Coveralls

ota-meshi requested changes

Jul 16, 2025

View reviewed changes

src/parser/typescript/analyze/index.ts Outdated

		"export function tracking(): boolean;",
		"export function root(fn: () => void \| (() => void)): () => void;",
		]);
		break;
		}
		// See https://github.com/sveltejs/svelte/blob/3c4a8d425b8192dc11ea2af256d531c51c37ba5d/packages/svelte/types/index.d.ts#L2997
		// See https://github.com/sveltejs/svelte/blob/3fa3dd78a1cbaa88a1571977b76bf6f02ed4231d/packages/svelte/types/index.d.ts#L3416
		case "$props": {
		// Use type parameters to avoid `@typescript-eslint/no-unsafe-assignment` errors.

Copy link

Member

ota-meshiJul 16, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the new comment explains it better, so I think this old comment is no longer necessary.

Suggested change

// Use type parameters to avoid `@typescript-eslint/no-unsafe-assignment` errors.

Copy link

MemberAuthor

baseballyamaJul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

removed:67b5adf

fix old comment

67b5adf

Copy link

MemberAuthor

baseballyama commentedJul 16, 2025

I will add more tests later.

@ota-meshi This PR needs to use ES2022 for top level await, What do you think? Is it ok? Or do we need to use some trick like(async () => await a + b)(); in virtual code?