Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: treat jsdoc with @typescript-eslint/parser#607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
baseballyama wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfix/533

Conversation

baseballyama
Copy link
Member

close:#533

@ota-meshi
In this PR, I made it so that scripts that appear to be JSDoc are parsed using@typescript-eslint/parser. I thought this would apply the types, but judging from the tests, it doesn’t seem to be working. Do you have any idea what might be wrong?

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedDec 1, 2024•
edited
Loading

⚠️ No Changeset found

Latest commit:cae678c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-newpkg.pr.new
Copy link

pkg-pr-newbot commentedDec 1, 2024•
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@607

commit:cae678c

@coveralls
Copy link

coveralls commentedDec 1, 2024•
edited
Loading

Pull Request Test Coverage Report forBuild 12326393889

Details

  • 89 of91(97.8%) changed or added relevant lines in3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at94.819%
Changes Missing CoverageCovered LinesChanged/Added Lines%
src/parser/parser-options.ts434595.56%
TotalsCoverage Status
Change from baseBuild 12251662727:0.0%
Covered Lines:10256
Relevant Lines:10693
💛 -Coveralls

@baseballyamabaseballyamaforce-pushed thefix/533 branch 2 times, most recently from16f1abb to8bb7ba1CompareDecember 1, 2024 13:01
@ota-meshi
Copy link
Member

There may be a problem with type inference in thetypescript core.
I think howtypescript infers types depends on ScriptKind. By default, ScriptKind is determined from the extension, so we may need to make ScriptKind recognize as JS. But I don't know how to do that well.

https://github.com/microsoft/TypeScript/blob/421f5c5458d09dad601604e6eff8765283aef14e/src/compiler/types.ts#L7584

@baseballyama
Copy link
MemberAuthor

Thank you. For now, I will prioritize addressing other issues.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSDoc types are lost in svelte files (typescript-eslint)
3 participants
@baseballyama@coveralls@ota-meshi
[8]ページ先頭
©2009-2025 Movatter.jp