Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: (experimental) partial support for Svelte v5 parser#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ota-meshi merged 7 commits intomainfromtest-svelte-v5
Nov 14, 2023

Conversation

@ota-meshi
Copy link
Member

@ota-meshiota-meshi commentedNov 14, 2023•
edited
Loading

related tosveltejs/eslint-plugin-svelte#587,#423

This PR is still a work in progress. It must support at least the following:

@changeset-bot
Copy link

changeset-botbot commentedNov 14, 2023•
edited
Loading

🦋 Changeset detected

Latest commit:8713722

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
svelte-eslint-parserMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commentedNov 14, 2023•
edited
Loading

Pull Request Test Coverage Report forBuild 6863695899

  • 34 of34(100.0%) changed or added relevant lines in1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to90.973%
TotalsCoverage Status
Change from baseBuild 6862417747:0.06%
Covered Lines:2236
Relevant Lines:2374
💛 -Coveralls

Copy link
Member

@baseballyamabaseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's LGTM. Thank you!
But how we will release it?
We will go to same way asprettier-plugin-svelte?
(Just release minor version.)

https://github.com/sveltejs/prettier-plugin-svelte/releases/tag/v3.1.0

@ota-meshiota-meshi mentioned this pull requestNov 14, 2023
18 tasks
@ota-meshi
Copy link
MemberAuthor

I'd like to release it at v0.34 if it doesn't contain breaking changes, but since it's still v0, minor releases may also require people to explicitly use the new version.
After ESLint v9 is released, I would like to release a major version of this parser and eslint-plguin-svelte.

baseballyama reacted with thumbs up emoji

@ota-meshiota-meshi changed the titlefeat: add experimental support for Svelte v5feat: (experimental) partial support for Svelte v5 parserNov 14, 2023
@ota-meshiota-meshi marked this pull request as ready for reviewNovember 14, 2023 12:39
@ota-meshiota-meshi merged commit59fc0e9 intomainNov 14, 2023
@ota-meshiota-meshi deleted the test-svelte-v5 branchNovember 14, 2023 12:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@baseballyamabaseballyamabaseballyama approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ota-meshi@coveralls@baseballyama
[8]ページ先頭
©2009-2025 Movatter.jp