Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor, change where validation occurs#1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Rich-Harris merged 15 commits intomasterfromvalidation
Sep 15, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

I'm abandoning#1718 (at least for now). The attempt gave me a sense of how we might structure the codebase slightly differently in order to make it easier to add alternative code generators. Before getting to that point, I wanted to address validation — currently, it's a bit of a convoluted and wasteful process, which could be made much easier by moving validation into the node constructors, instead of having a separateValidator class which duplicates a lot of stuff.

The other notable changes so far in this PR are that the internalCompiler class becomesComponent (since it represents the component being compiled — it makes more sense to speak of e.g.component.transitions thancompiler.transitions). This means that the existingComponent class has been renamed toInlineComponent.

Also, thesrc/index.ts file has been radically simplified by moving things into the folders where they belong. My hope is that this will make it easier for people to ease their way into the codebase.

@Rich-HarrisRich-Harris changed the title[WIP] Refactor, change where validation occursRefactor, change where validation occursSep 15, 2018
@Rich-HarrisRich-Harris merged commit9031c16 intomasterSep 15, 2018
@Rich-HarrisRich-Harris deleted the validation branchSeptember 15, 2018 21:37
@Rich-Harris
Copy link
MemberAuthor

Lots of follow-up work to happen here, but it can happen in follow-up PRs

antonheryanto and schneiderfelipe reacted with thumbs up emojinsivertsen and schneiderfelipe reacted with hooray emoji

@Rich-HarrisRich-Harris mentioned this pull requestSep 15, 2018
@tanhauhautanhauhau mentioned this pull requestOct 17, 2019
23 tasks
jschaf added a commit to jschaf/svelte that referenced this pull requestMay 22, 2025
The spec states the title element supports global attributes.https://html.spec.whatwg.org/#the-title-elementReverts the title attribute validation introduced insveltejs#1721.Fixessveltejs#5198.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Rich-Harris

[8]ページ先頭

©2009-2025 Movatter.jp