Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.6k
fix: allow instrinsic<svelte:...>
elements to inherit fromSvelteHTMLElements
#16424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
🦋 Changeset detectedLatest commit:7a4a9d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
(context: this was original pulled over from language-tools, but it's kinda obsolete sinceelements.d.ts
provides all these already and overriding them is not sensible; Svelte will complain about anything that's not an event/binding on these)
98fb1b1
intomainUh oh!
There was an error while loading.Please reload this page.
supersedes#16390
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint