Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: better handle $inspect on array mutations#16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Rich-Harris merged 3 commits intomainfromfix-16375
Jul 16, 2025
Merged

Conversation

7nik
Copy link
Contributor

Fixes#16375, and now $inspect is called only once per array-mutating method.

I guess nobody will do something like

letarr=$state([1,2,3]);arr.shift=()=>{thrownewError()};// will make $inspect deferred until a successful call of array mutating method$inspect(arr);// laterarr.shift();

or in another way make the methods throwable because it's shooting into one's own leg.

Also,Array.prototype.shift.call(arr) will still trigger $inspect on each step. But patching the Array prototype is too much?

About the testinspect-console-trace - the error stack was expected to haveat HTMLButtonElement.<anonymous> (path) but now it isn't in the last 10 stack calls.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 16, 2025
edited
Loading

🦋 Changeset detected

Latest commit:5273f70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16389

Copy link
Member

@Rich-HarrisRich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

love this fix

@Rich-HarrisRich-Harris merged commit6cf3a19 intomainJul 16, 2025
15 checks passed
@Rich-HarrisRich-Harris deleted the fix-16375 branchJuly 16, 2025 13:55
@github-actionsgithub-actionsbot mentioned this pull requestJul 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Rich-HarrisRich-HarrisRich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create a sparse array in runes mode
2 participants
@7nik@Rich-Harris

[8]ページ先頭

©2009-2025 Movatter.jp