Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: clean up a11y analysis code#16345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Ocean-OS merged 10 commits intomainfromcleanup-a11y
Jul 14, 2025
Merged

chore: clean up a11y analysis code#16345

Ocean-OS merged 10 commits intomainfromcleanup-a11y
Jul 14, 2025

Conversation

Ocean-OS
Copy link
Contributor

When reviewing#16340,#16341, and#16339 I realized how unorganized the code inpackages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js was, so I split it into two files and cleaned up a few things.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 11, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:21ed6c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16345

@dummdidumm
Copy link
Member

"Few things" are from what I can see mainly if->switch? Anything else?
I think we should name ita11y/index.js nota11y/utils.js, otherwise looks good.

@Ocean-OS
Copy link
ContributorAuthor

iirc that's all, I'll rename it in a bit

@Ocean-OSOcean-OS merged commit82f6481 intomainJul 14, 2025
14 checks passed
@Ocean-OSOcean-OS deleted the cleanup-a11y branchJuly 14, 2025 19:06
@github-actionsgithub-actionsbot mentioned this pull requestJul 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Rich-HarrisRich-HarrisRich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Ocean-OS@dummdidumm@Rich-Harris
[8]ページ先頭
©2009-2025 Movatter.jp