Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: silence a11y warning for inert elements#16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Rich-Harris merged 5 commits intosveltejs:mainfromnavorite:main
Jul 14, 2025

Conversation

navorite
Copy link
Contributor

@navoritenavorite commentedJul 11, 2025
edited
Loading

closes#15814

I thought about a case where the children are inside an inert parent, perhaps in this case we should skip a11y validation altogether for all the children?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC:https://github.com/sveltejs/rfcs
  • Prefix your PR title withfeat:,fix:,chore:, ordocs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code withinpackages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests withpnpm test and lint the project withpnpm lint

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 11, 2025
edited
Loading

🦋 Changeset detected

Latest commit:34c03c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
sveltePatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsGitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16339

@Ocean-OSOcean-OS mentioned this pull requestJul 11, 2025
6 tasks
@svelte-docs-bot
Copy link

@Rich-Harris
Copy link
Member

thanks!

perhaps in this case we should skip a11y validation altogether for all the children?

wecould... though it seems like a real edge case tbh so i'm inclined to cross that bridge when we come to it

@Rich-HarrisRich-Harris merged commit63b5ebf intosveltejs:mainJul 14, 2025
10 checks passed
@github-actionsgithub-actionsbot mentioned this pull requestJul 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Rich-HarrisRich-HarrisRich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect aria-label reminder for inert buttons
2 participants
@navorite@Rich-Harris

[8]ページ先頭

©2009-2025 Movatter.jp